1321312 - Add command-line argument to re-enable crash reporter when using ./mach run

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

I periodically debug about:tabcrashed. Bug 1240142 made it so that by default, the crash reporter is not enabled when using ./mach run. I totally agree with that decision, but when debugging about:tabcrashed, it's actually kind of annoying. In order to properly test our crash reporting infrastructure when using ./mach run, I have to manually edit python/mozbuild/mozbuild/mach_commands.py to get rid of the MOZ_CRASHREPORTER_DISABLE environment variable.

I'd like to add a --enable-crash-reporter to ./mach run which will allow me to create crash reports when using ./mach run.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1321312 - Add --enable-crash-reporter to ./mach run.

Review commit: https://reviewboard.mozilla.org/r/96582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96582/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8815770 [details]
Bug 1321312 - Add --enable-crash-reporter to ./mach run.

https://reviewboard.mozilla.org/r/96582/#review96930

Makes sense. Thanks for the feature!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a7865514be5
Add --enable-crash-reporter to ./mach run. r=gps

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3a7865514be5