1321330 - we really love our --allow-software-gl-layers in the configs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

from production m-c linux marionette (https://tools.taskcluster.net/task-inspector/#D7filN9tRGmG3DQcjXXzeA/):
  "command": [
    "/home/worker/bin/run-task",
    "--chown",
    "/home/worker/workspace",
    "--",
    "/home/worker/bin/test-linux.sh",
    "--no-read-buildbot-config",
    "--installer-url=https://queue.taskcluster.net/v1/task/QS445WmxRHSEUCsYX6IlAw/artifacts/public/build/target.tar.bz2",
    "--test-packages-url=https://queue.taskcluster.net/v1/task/QS445WmxRHSEUCsYX6IlAw/artifacts/public/build/target.test_packages.json",
    "--allow-software-gl-layers",
    "--allow-software-gl-layers",
    "--allow-software-gl-layers",
    "--allow-software-gl-layers",
    "--allow-software-gl-layers",
    "--e10s",
    "--allow-software-gl-layers",
    "--download-symbols=ondemand"
  ],


I assume it is coming from this transform:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests/desktop_test.py#92

given that this occurs 6 times, would it be an educated guess to say we have 6 different kinds of desktop tests that we run the transforms on?

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

If I had to guess, I'd say it was a data-aliasing error.  The six is probably from 3 platforms x 2 e10s/non, each of them appending to the same list.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1321330: fix some aliasing issues;

Always copy objects after schema validation applies defaults, in case the
defaults are mutable (`.., default=[]`)

When duplicating objects for e10s, copy *before* yielding, as the object will
be mutated before the yield returns.

As a consequence of the previous point, tests have not yet had `extra-options`
expanded via `by-test-platform` when it comes time to append to it, so perform
that expansion early.  This will get cleaner when bug 1302192 is completd.

Review commit: https://reviewboard.mozilla.org/r/96602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96602/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8815819 [details]
Bug 1321330: fix some aliasing issues;

https://reviewboard.mozilla.org/r/96602/#review96858

thanks for fixing this!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c4f3476db84
fix some aliasing issues; r=jmaher

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8c4f3476db84