1321344 - "TypeError: expected string or buffer" in commitparser.parse_reviewers

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Florian Quèze [:florian]]

https://hg.mozilla.org/try/rev/58582ed407352b264bb09525ecb2b42d2c2520ef shows:

Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator at root@localhost to inform them of the time this error occurred, and the actions you performed just before this error.

More information about this error may be available in the server error log.

Comment 1

[Gregory Szorc [:gps]]

Thanks for reporting. Looks like an issue in our reviewer parsing code. 

[Wed Nov 30 19:48:15.944347 2016] [wsgi:error] [pid 26263] [remote 127.0.0.1:9728]     for reviewer in commitparser.parse_reviewers(description):
[Wed Nov 30 19:48:15.944352 2016] [wsgi:error] [pid 26263] [remote 127.0.0.1:9728]   File "/var/hg/version-control-tools/pylib/mozautomation/mozautomation/commitparser.py", line 104, in parse_reviewers
[Wed Nov 30 19:48:15.944410 2016] [wsgi:error] [pid 26263] [remote 127.0.0.1:9728]     for reviewer in re.split(LIST_RE, match.group(3)):
[Wed Nov 30 19:48:15.944419 2016] [wsgi:error] [pid 26263] [remote 127.0.0.1:9728]   File "/var/hg/venv_hgweb/lib64/python2.7/re.py", line 167, in split
[Wed Nov 30 19:48:15.944510 2016] [wsgi:error] [pid 26263] [remote 127.0.0.1:9728]     return _compile(pattern, flags).split(string, maxsplit)
[Wed Nov 30 19:48:15.944528 2016] [wsgi:error] [pid 26263] [remote 127.0.0.1:9728] TypeError: expected string or buffer

The commit message is "Bug 1313324 - Cover the screensharing UI with browser chrome test, r="

Looks like this is a regression from bug 1320251.

glob: can you please triage?

Comment 2

[Gregory Szorc [:gps]]

This is more widespread than I thought. We can't wait for the sun (and glob) to rise in Perth.

Comment 3

[Gregory Szorc [:gps]]

Attachment: mozautomation: handle empty reviewer string (bug 1321344);

97701ae2f512 (bug 1320251) changed the reviewer regular expression
slightly to allow optional characters after the review specifier so
we could detect bare "r?" or "r=". Unfortunately, parse_reviewers()
assumed this regexp match had a value and was subsequently failing
to operate on a None value.

This commit adds an explicit value check to stop that error.

The added tests triggered the same stack observed in the bug before
parse_reviewers() was updated. So I'm pretty confident this will
fix the issue.

Review commit: https://reviewboard.mozilla.org/r/96648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96648/

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8815871 [details]
mozautomation: handle empty reviewer string (bug 1321344);

https://reviewboard.mozilla.org/r/96648/#review96884

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/b3f0bd3ea317
mozautomation: handle empty reviewer string ; r=smacleod

Comment 6

[Gregory Szorc [:gps]]

This is deployed.