Closed Bug 1321398 Opened 8 years ago Closed 3 years ago

GYP build fails without "python" symlink

Categories

(NSS :: Build, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jbeich, Unassigned)

References

Details

Attachments

(1 file)

Downstream may not have "python" installed or want to build with specific version. NSS built as part of mozilla-central is unaffected. Does mozbuild GYP parses implicitly pass -Dpython=sys.executable?

  $ cd /path/to/nss
  $ ./build.sh
  ./build.sh:68: command not found: python
$ ./build.sh
[...]
/bin/sh: python: not found
gyp: Call to 'python ./coreconf/detect_host_arch.py' returned exit status 127 while in /tmp/nss/nss.gyp.
See Also: → 1321403
I don't think this should still be a problem. Please re-open if it still is.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
$ ./build.sh
./build.sh: line 60: python: command not found
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Well if python isn't available on the system, I don't think the build will work.
python2.7 and python3.6 are available. The former has no issues to be found by mach in Gecko which also respects $PYTHON variable.
All this really needs is a `PYTHON=${PYTHON:-python}` similar to what we already have for gyp:
https://hg.mozilla.org/projects/nss/annotate/711b3866b2ce/build.sh#l18

and then using that where we currently use `python`:
https://hg.mozilla.org/projects/nss/annotate/711b3866b2ce/build.sh#l60

We might also need to explicitly run `${PYTHON} ${GYP} ...` because gyp's shebang might not do the right thing.
Status: REOPENED → RESOLVED
Closed: 7 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: