1321398 - GYP build fails without "python" symlink

Status: RESOLVED FIXED

(NSS :: Build, defect, P3)

Description

[Jan Beich]

Downstream may not have "python" installed or want to build with specific version. NSS built as part of mozilla-central is unaffected. Does mozbuild GYP parses implicitly pass -Dpython=sys.executable?

  $ cd /path/to/nss
  $ ./build.sh
  ./build.sh:68: command not found: python

Comment 1

[Jan Beich]

$ ./build.sh
[...]
/bin/sh: python: not found
gyp: Call to 'python ./coreconf/detect_host_arch.py' returned exit status 127 while in /tmp/nss/nss.gyp.

Comment 2

[Franziskus Kiefer [:franziskus]]

I don't think this should still be a problem. Please re-open if it still is.

Comment 3

[Jan Beich]

$ ./build.sh
./build.sh: line 60: python: command not found

Comment 4

[Franziskus Kiefer [:franziskus]]

Well if python isn't available on the system, I don't think the build will work.

Comment 5

[Jan Beich]

python2.7 and python3.6 are available. The former has no issues to be found by mach in Gecko which also respects $PYTHON variable.

Comment 6

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Bulk change per wleung.

Comment 7

[(not currently active) Ted Mielczarek]

All this really needs is a `PYTHON=${PYTHON:-python}` similar to what we already have for gyp:
https://hg.mozilla.org/projects/nss/annotate/711b3866b2ce/build.sh#l18

and then using that where we currently use `python`:
https://hg.mozilla.org/projects/nss/annotate/711b3866b2ce/build.sh#l60

We might also need to explicitly run `${PYTHON} ${GYP} ...` because gyp's shebang might not do the right thing.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1321398 - Allow to override python for the build.

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/projects/nss/rev/c468deab26338621ce875bfaaa8cbdb2058761ab