GYP build fails with python 3.x

RESOLVED FIXED in 3.29

Status

NSS
Build
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

trunk
3.29

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
$ ./build.sh
[1/3] configure NSPR ...
[2/3] make NSPR ...
[3/3] install NSPR ...
  File "./coreconf/check_cc_clang.py", line 9
    print 0
          ^
SyntaxError: Missing parentheses in call to 'print'
  File "./coreconf/check_cc_clang.py", line 17
    print int(cc_is_clang)
            ^
SyntaxError: invalid syntax

Traceback (most recent call last):
  File "./coreconf/check_cc_clang.py", line 20, in <module>
    main()
  File "./coreconf/check_cc_clang.py", line 13, in main
    cc_is_clang = 'clang' in subprocess.check_output([cc, '--version'])
TypeError: a bytes-like object is required, not 'str'

Traceback (most recent call last):
  File "./coreconf/werror.py", line 59, in <module>
    main()
  File "./coreconf/werror.py", line 10, in main
    cc_is_clang = 'clang' in subprocess.check_output([cc, '--version'], stderr=sink)
TypeError: a bytes-like object is required, not 'str'

$ python --version
Python 3.5.2
(Assignee)

Updated

2 years ago
See Also: → bug 1321398
(Assignee)

Comment 1

2 years ago
Created attachment 8815905 [details] [diff] [review]
nss-gyp-py3k.diff

For some reason GYP itself is slow with python 3.5 here.

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=505657db11d1f544d2428226753d70476ff2e701
Attachment #8815905 - Flags: review?(ted)
Attachment #8815905 - Flags: review?(ted) → review+
https://hg.mozilla.org/projects/nss/rev/2605997df4f335e67834310b255f0e7892e56cfb
Assignee: nobody → jbeich
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → 3.29
You need to log in before you can comment on or make changes to this bug.