Fix localization note and key for inspector.sidebar.layoutViewTitle

RESOLVED FIXED in Firefox 53

Status

RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

52 Branch
Firefox 53

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(In reply to Ton from Bug 1305786 comment #11)
> (In reply to Carsten Book [:Tomcat] from Bug 1305786 comment #10)
> > https://hg.mozilla.org/mozilla-central/rev/7aeb526759fe
> > 
> > +# LOCALIZATION NOTE (inspector.sidebar.computedViewTitle):
> > +# This is the title shown in a tab in the side panel of the Inspector panel
> > +# that corresponds to the tool displaying layout information defined in the page.
> > +inspector.sidebar.layoutViewTitle=Layout
> 
> Note and entity mismatch.
> 
> Additionally, "Layout" and "Box Model" appear to be inconsistent and cause
> confusion, looking at various locales, likely because it used to be called
> Box Model and changed silently without entity change.
> Can this be fixed?
> 
> https://hg.mozilla.org/mozilla-central/rev/f249501590e6
> https://hg.mozilla.org/mozilla-central/rev/41f5b98f7b55
> https://transvision.mozfr.org/string/?entity=devtools/client/inspector.
> properties:inspector.sidebar.layoutViewTitle&repo=aurora

sidebar.layoutViewTitle was removed from inspector.properties in Bug 1294186, and was readded in Bug 1305786, but for a different meaning. Localization tools have no way to differentiate the too so we should update the key here. 

Localization note is also off.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8816070 [details]
Bug 1321504 - update localization note and key for layout view title;

https://reviewboard.mozilla.org/r/96858/#review97096

::: devtools/client/locales/en-US/inspector.properties:327
(Diff revision 1)
>  inspector.sidebar.computedViewTitle=Computed
>  
> -# LOCALIZATION NOTE (inspector.sidebar.computedViewTitle):
> +# LOCALIZATION NOTE (inspector.sidebar.layoutViewTitle2):
>  # This is the title shown in a tab in the side panel of the Inspector panel
>  # that corresponds to the tool displaying layout information defined in the page.
> -inspector.sidebar.layoutViewTitle=Layout
> +# Not related to the previous string "inspector.sidebar.layoutViewTitle" that referred to

You can skip this part. Since the ID changes, they'll be force to retranslate the string.
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8816070 [details]
Bug 1321504 - update localization note and key for layout view title;

https://reviewboard.mozilla.org/r/96858/#review97096

> You can skip this part. Since the ID changes, they'll be force to retranslate the string.

Thanks, was not sure if that could be helpful or not. Updated.
Comment hidden (mozreview-request)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8816070 [details]
Bug 1321504 - update localization note and key for layout view title;

https://reviewboard.mozilla.org/r/96858/#review97116
Attachment #8816070 - Flags: review?(gl) → review+

Comment 6

2 years ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bb4237ef574
update localization note and key for layout view title;r=gl

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2bb4237ef574
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.