autoland fails to land gecko:ad83087831c6 - unknown revision "

RESOLVED FIXED

Status

MozReview
Autoland
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
https://reviewboard.mozilla.org/r/95398/diff/3

hg error in cmd: hg rewritecommitdescriptions --descriptions=/tmp/tmpBVIVJW ad83087831c65e4c4736efe90d455072742a8cc8: saved backup bundle to /repos/mozreview-gecko/.hg/strip-backup/2a520851d322-c370f1c1-replacing.hg
warning: ignoring unknown working parent adf44fc5e1a6!
rev: 4575b3e40429 -> fba00a9fc212
rev: 2a520851d322 -> ac27634cc312
abort: unknown revision 'adf44fc5e1a68d29ddaec7b8f0e96adc53a624d9'!
(Assignee)

Comment 1

2 years ago
steps to reproduce:

edit your .hgrc file to enable rewritecommitdescriptions and disable evolve extensions
> [extensions]
> # evolve = ~/.hg_extensions/evolve-main/hgext/evolve.py
> rewritecommitdescriptions = ~/.mozbuild/version-control-tools/autoland/hgext/rewritecommitdescriptions.py

take a fresh clone of mozilla-central
> hg clone https://hg.mozilla.org/mozilla-central/

pull down the review request
> hg pull https://reviewboard-hg.mozilla.org/gecko -r ad83087831c65e4c4736efe90d455072742a8cc8
> hg update ad83087831c65e4c4736efe90d455072742a8cc8

create json file with commit descriptions
> echo '{"4575b3e4042989971c89aa304d6ab625b4c969ef":"Bug 1320084 - Remove unused devtools/client/themes/dom.css file. r=Honza\n\nMozReview-Commit-ID: 1sjsBmMUlGz","2a520851d322aa927a6fc705762351d75a5c01d3":"Bug 1320084 - Remove project editor test files from firefox package. r=bgrins\n\nMozReview-Commit-ID: FBvL2jtL2LZ","ad83087831c65e4c4736efe90d455072742a8cc8":"Bug 1320084 - Remove useless devtools JSM shims. r=jryans\n\nMozReview-Commit-ID: JUui79wiNYi"}' > rewrite.json

rewrite
> hg rewritecommitdescriptions --descriptions=rewrite.json ad83087831c65e4c4736efe90d455072742a8cc8
(Assignee)

Comment 3

a year ago
sorry this is taking so long; i've been on pto, and have limited time to look at it this week.

looks like this is caused by a node that doesn't require a commit description rewrite being stripped.  i have a fix in hand which i'll put up for review once i've done more testing.
Assignee: nobody → glob
(Assignee)

Updated

a year ago
Duplicate of this bug: 1316227
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8826598 [details]
autoland: fix "unknown revision" errors when rewriting commit descriptions (bug 1321548)

https://reviewboard.mozilla.org/r/104532/#review105196
Attachment #8826598 - Flags: review?(smacleod) → review+

Comment 7

a year ago
Pushed by smacleod@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/e7a1797d902a
autoland: fix "unknown revision" errors when rewriting commit descriptions r=smacleod
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 8

a year ago
backed out due to test failures (urgh, sorry!)

https://hg.mozilla.org/hgcustom/version-control-tools/rev/cb2ae982d50564ef215aed77b71492bb20738088
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

a year ago
mozreview-review
Comment on attachment 8832353 [details]
mozhg: don't strip/obsolete unmodified revisions during rewrite (bug bug 1321548)

https://reviewboard.mozilla.org/r/108676/#review109938

Good catch.

I'm surprised this bug hasn't bit us more.
Attachment #8832353 - Flags: review?(gps) → review+
(Assignee)

Updated

a year ago
Attachment #8826598 - Flags: review+ → review?
(Assignee)

Updated

a year ago
Attachment #8826598 - Flags: review? → review?(smacleod)

Comment 12

a year ago
mozreview-review
Comment on attachment 8826598 [details]
autoland: fix "unknown revision" errors when rewriting commit descriptions (bug 1321548)

https://reviewboard.mozilla.org/r/104532/#review114170
Attachment #8826598 - Flags: review?(smacleod) → review+

Comment 13

a year ago
Pushed by smacleod@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/f9e20419aa59
mozhg: don't strip/obsolete unmodified revisions during rewrite (bug bug 1321548) r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1af53eaac838
autoland: fix "unknown revision" errors when rewriting commit descriptions r=smacleod
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED

Updated

4 months ago
Duplicate of this bug: 1311852
You need to log in before you can comment on or make changes to this bug.