1321583 - Baldr: freeze the exports object

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

To match https://github.com/WebAssembly/design/pull/880

Comment 1

[Luke Wagner [:luke]]

Attachment: freeze

Super easy.

Comment 2

[Luke Wagner [:luke]]

Attachment: freeze

Oops, needed to update some other tests that were implicitly relying on extensibility.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8816607 [details] [diff] [review]
freeze

Review of attachment 8816607 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6270d8941a
Baldr: freeze the exports object (r=bbouvier)

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8816607 [details] [diff] [review]
freeze

Approval Request Comment
[Feature/Bug causing the regression]: new feature in spec, not a bug
[User impact if declined]: missing feature in initial wasm release
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: small and self-contained

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bf6270d8941a

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8816607 [details] [diff] [review]
freeze

wasm update for aurora52

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9e9258e65854