1321631 - Lazy load audio file for screenshot button

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I don't have specific perf numbers for this one, but I've noticed in debug builds that the platform is auto-loading the screenshot audio during page load (before we've called play).

It's only used if you click a specific button, so let's delay it until then.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1321631 - Delay loading RDM camera audio until used.

Review commit: https://reviewboard.mozilla.org/r/97052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97052/

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8816247 [details]
Bug 1321631 - Delay loading RDM camera audio until used.

https://reviewboard.mozilla.org/r/97052/#review97254

Looks sensible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6060c3c56342
Delay loading RDM camera audio until used. r=ochameau

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6060c3c56342

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8816247 [details]
Bug 1321631 - Delay loading RDM camera audio until used.

Approval Request Comment
[Feature/Bug causing the regression]: Slow loading time in new Responsive Design Mode (first enabled in 52)
[User impact if declined]: Loading time will remain slow
[Is this code covered by automated tests?]: No, it's a perf optimization only
[Has the fix been verified in Nightly?]: Tested locally
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects UI of RDM
[String changes made/needed]: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8816247 [details]
Bug 1321631 - Delay loading RDM camera audio until used.

tweak devtools RDM for a perf improvement, take in aurora52

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a4ac66258d4