Lazy load audio file for screenshot button

RESOLVED FIXED in Firefox 52

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

(Blocks 1 bug)

49 Branch
Firefox 53
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: [rdm-v2])

Attachments

(1 attachment)

Assignee

Description

3 years ago
I don't have specific perf numbers for this one, but I've noticed in debug builds that the platform is auto-loading the screenshot audio during page load (before we've called play).

It's only used if you click a specific button, so let's delay it until then.
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8816247 [details]
Bug 1321631 - Delay loading RDM camera audio until used.

https://reviewboard.mozilla.org/r/97052/#review97254

Looks sensible.
Attachment #8816247 - Flags: review?(poirot.alex) → review+

Comment 3

3 years ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6060c3c56342
Delay loading RDM camera audio until used. r=ochameau

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6060c3c56342
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Assignee

Comment 5

3 years ago
Comment on attachment 8816247 [details]
Bug 1321631 - Delay loading RDM camera audio until used.

Approval Request Comment
[Feature/Bug causing the regression]: Slow loading time in new Responsive Design Mode (first enabled in 52)
[User impact if declined]: Loading time will remain slow
[Is this code covered by automated tests?]: No, it's a perf optimization only
[Has the fix been verified in Nightly?]: Tested locally
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects UI of RDM
[String changes made/needed]: None
Attachment #8816247 - Flags: approval-mozilla-aurora?
Comment on attachment 8816247 [details]
Bug 1321631 - Delay loading RDM camera audio until used.

tweak devtools RDM for a perf improvement, take in aurora52
Attachment #8816247 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.