[RTL] [History page] Strings indicating the time history items were created are LTR

VERIFIED FIXED in Firefox 53

Status

()

Firefox for Android
Theme and Visual Design
P5
normal
VERIFIED FIXED
7 months ago
5 months ago

People

(Reporter: ItielMaN, Assigned: maliu)

Tracking

(Blocks: 1 bug, {rtl})

unspecified
Firefox 53
Unspecified
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

7 months ago
Created attachment 8816250 [details]
Screenshot

Under History section in a New Tab page, the strings indicating the time history items were created are LTR (or not being respected as BiDi?).

Screenshot attached.

Comment 1

7 months ago
I think they are just aligned to the left instead of being aligned to the right, the text is perfectly RTL (OK, one will need a longer date to confirm, I only see today here as well).
(Reporter)

Comment 2

7 months ago
(In reply to Khaled Hosny from comment #1)
> I think they are just aligned to the left instead of being aligned to the
> right

Yeah, that's what I meant.

(In reply to Khaled Hosny from comment #1)
> one will need a longer date to
> confirm, I only see today here as well

Same here.
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Assignee: nobody → max
Comment on attachment 8819282 [details]
Bug 1321635 - Align history section header by left|start in styles.xml,

https://reviewboard.mozilla.org/r/99130/#review99402
Attachment #8819282 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 5

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f8e550969421
Align history section header by left|start in styles.xml, r=sebastian
Keywords: checkin-needed
(Reporter)

Comment 6

6 months ago
I see no change whatsoever on latest Nightly, the timestamps still appear on the left.
Running the Hebrew Nightly, Samsung Galaxy S5 G900F Android 6.0.1.

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f8e550969421
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Reporter)

Comment 8

6 months ago
I can confirm the bug is fixed in latest Nightly.
tracking-fennec: --- → ?
tracking-fennec: ? → ---
Blocks: 1319302

Comment 9

5 months ago
(In reply to ItielMaN from comment #8)
> I can confirm the bug is fixed in latest Nightly.

Moving it to Verified Fixed as per comment #8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.