Last Comment Bug 1321641 - Use built-in functions instead of an svg for bubbles filter
: Use built-in functions instead of an svg for bubbles filter
Status: RESOLVED FIXED
:
Product: Instantbird
Classification: Client Software
Component: Other (show other bugs)
: trunk
: Unspecified Unspecified
-- normal
: ---
Assigned To: arlolra
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-12-01 13:13 PST by arlolra
Modified: 2016-12-01 15:44 PST (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch (3.58 KB, patch)
2016-12-01 13:13 PST, arlolra
no flags Details | Diff | Splinter Review
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch from comment 1 (3.57 KB, patch)
2016-12-01 13:18 PST, arlolra
clokep: review+
Details | Diff | Splinter Review

Description User image arlolra 2016-12-01 13:13:19 PST
Created attachment 8816259 [details] [diff] [review]
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36
Comment 1 User image arlolra 2016-12-01 13:15:22 PST
Comment on attachment 8816259 [details] [diff] [review]
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch

Review of attachment 8816259 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/themes/messages/bubbles/bubbles.svg
@@ -4,5 @@
> -   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> -
> -<svg xmlns="http://www.w3.org/2000/svg">
> -  <filter id="desaturate">
> -    <feColorMatrix type="saturate" values="0.4"/>

Hmm, maybe I should have just used `saturate()`?
Comment 2 User image arlolra 2016-12-01 13:18:00 PST
Created attachment 8816263 [details] [diff] [review]
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch from comment 1
Comment 3 User image Patrick Cloke [:clokep] 2016-12-01 13:31:53 PST
Please provide a description of why this is an issue and what it's fixing.
Comment 4 User image arlolra 2016-12-01 13:42:36 PST
Tor Browser has this Firefox patch that let's you disable svg in content,
https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-45.5.1esr-6.0-1&id=32bd056a3c5643bf133d7395ffebd657c5af0d24

We'd like to enable that in Tor Messenger but bubbles uses this svg and previous messages just end up not rendering.

Plus, why do something with an external svg that css has native support for?

Note You need to log in before you can comment on or make changes to this bug.