Use built-in functions instead of an svg for bubbles filter

RESOLVED FIXED

Status

Instantbird
Other
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: arlolra, Assigned: arlolra)

Tracking

trunk

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 months ago
Created attachment 8816259 [details] [diff] [review]
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36
(Assignee)

Updated

7 months ago
Attachment #8816259 - Attachment is patch: true
Attachment #8816259 - Attachment mime type: text/x-patch → text/plain
Attachment #8816259 - Flags: review?(clokep)
(Assignee)

Comment 1

7 months ago
Comment on attachment 8816259 [details] [diff] [review]
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch

Review of attachment 8816259 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/themes/messages/bubbles/bubbles.svg
@@ -4,5 @@
> -   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> -
> -<svg xmlns="http://www.w3.org/2000/svg">
> -  <filter id="desaturate">
> -    <feColorMatrix type="saturate" values="0.4"/>

Hmm, maybe I should have just used `saturate()`?
(Assignee)

Comment 2

7 months ago
Created attachment 8816263 [details] [diff] [review]
0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch from comment 1
Attachment #8816259 - Attachment is obsolete: true
Attachment #8816259 - Flags: review?(clokep)
Attachment #8816263 - Flags: review?(clokep)
Please provide a description of why this is an issue and what it's fixing.
Flags: needinfo?(arlolra)
(Assignee)

Comment 4

7 months ago
Tor Browser has this Firefox patch that let's you disable svg in content,
https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-45.5.1esr-6.0-1&id=32bd056a3c5643bf133d7395ffebd657c5af0d24

We'd like to enable that in Tor Messenger but bubbles uses this svg and previous messages just end up not rendering.

Plus, why do something with an external svg that css has native support for?
Flags: needinfo?(arlolra)

Updated

7 months ago
Attachment #8816263 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/75f891b74ae80e5e0c7627d0659e810830d2963d

Thanks!
Assignee: nobody → arlolra
Status: UNCONFIRMED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.