Closed
Bug 1321641
Opened 7 years ago
Closed 7 years ago
Use built-in functions instead of an svg for bubbles filter
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arlolra, Assigned: arlolra)
Details
Attachments
(1 file, 1 obsolete file)
3.57 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36
Attachment #8816259 -
Attachment is patch: true
Attachment #8816259 -
Attachment mime type: text/x-patch → text/plain
Attachment #8816259 -
Flags: review?(clokep)
Comment on attachment 8816259 [details] [diff] [review] 0001-Use-built-in-functions-instead-of-an-svg-for-bubbles.patch Review of attachment 8816259 [details] [diff] [review]: ----------------------------------------------------------------- ::: im/themes/messages/bubbles/bubbles.svg @@ -4,5 @@ > - - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> > - > -<svg xmlns="http://www.w3.org/2000/svg"> > - <filter id="desaturate"> > - <feColorMatrix type="saturate" values="0.4"/> Hmm, maybe I should have just used `saturate()`?
Attachment #8816259 -
Attachment is obsolete: true
Attachment #8816259 -
Flags: review?(clokep)
Attachment #8816263 -
Flags: review?(clokep)
Comment 3•7 years ago
|
||
Please provide a description of why this is an issue and what it's fixing.
Flags: needinfo?(arlolra)
Tor Browser has this Firefox patch that let's you disable svg in content, https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-45.5.1esr-6.0-1&id=32bd056a3c5643bf133d7395ffebd657c5af0d24 We'd like to enable that in Tor Messenger but bubbles uses this svg and previous messages just end up not rendering. Plus, why do something with an external svg that css has native support for?
Flags: needinfo?(arlolra)
Updated•7 years ago
|
Attachment #8816263 -
Flags: review?(clokep) → review+
Comment 5•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/75f891b74ae80e5e0c7627d0659e810830d2963d Thanks!
Assignee: nobody → arlolra
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•