Closed Bug 1321707 Opened 3 years ago Closed 3 years ago

Intermittent w3c-css/submitted/ui3/box-sizing-replaced-001.xht == w3c-css/submitted/ui3/box-sizing-replaced-001-ref.xht | image comparison, max difference: 255, number of differing pixels: 900

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jmaher)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(2 files)

This intermittent test failure happened from 2016/12, those are only happened on debug build...

As comment 7 said it comes down to (landed on Jan)https://hg.mozilla.org/integration/autoland/rev/30d0b78371d543b6691a4edbb1f57628917fd562

The change just makes the MOZ_ASSERT to MOZ_RELEASE_ASSERT which makes us be more aggressive to detect the misusing of mozilla::Variant and we can see the intermittent failure started to occur on non-debug build.

Since I'm not the layout guy, I cannot tell what happened.

Hi Astley,
Would you please help to dispatch this issue to a suitable person to see how the code related to Variant?
Since the assertion is obvious to know there must have some error casting by ```Variant::as<ToSomeErrorType>```

Thank you.
Flags: needinfo?(jacheng) → needinfo?(aschen)
James, suppose the test will generate error casting log as you mentioned.
But I didn't find it in relevant android tests failure provided in comment 7.
I'll do a simple local test and see if the relevant log can be discovered and create some clues for further debugging.

Leave ni for tracking.
I think the pattern is showing both android and linux* as culprits to this.  Astley, do you need any help or more information to help solve this?
will disable this test until Astley has time to look at this. Astley, you can easily test this locally or on try by removing the edits in reftest.list.
Assignee: nobody → jmaher
Attachment #8834001 - Flags: review?(gbrown)
Comment on attachment 8834001 [details] [diff] [review]
disable reftest on linux/android

Review of attachment 8834001 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add "bug 1321707" to the comment?
Attachment #8834001 - Flags: review?(gbrown) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86e50de186e9
Intermittent w3c-css/submitted/ui3/box-sizing-replaced-001.xht skip on android/linux. r=gbrown
https://hg.mozilla.org/mozilla-central/rev/86e50de186e9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
this isn't fixing everything, :ryanvm suspects order of skip-if vs other clauses in the reftest.list
Status: RESOLVED → REOPENED
Flags: needinfo?(jmaher)
Resolution: FIXED → ---
odd that these are failing now, I see android failing as well- this indicates a parser error.  I verified with local hacking that skip-if() can come before fuzzy-if(), also with some logs where we have prior art of skip-if() showing up before fuzzy-if().

So I pushed to try a few times to see if this test case is getting skipped with various adjustments.
try server confirmed what :ryanvm said- there must be other clues to figure this out which I am missing- either way, this patch solves the immediate problem.
Flags: needinfo?(jmaher)
Attachment #8834575 - Flags: review?(gbrown)
Comment on attachment 8834575 [details] [diff] [review]
fix reftest.list ordering of skip-if fuzzy-if

Review of attachment 8834575 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand why this is necessary, but I have seen similar unexpected issues....not surprised.

Is there a bug for the generic manifest problem?
Attachment #8834575 - Flags: review?(gbrown) → review+
I filed bug 1337766 to investigate the manifest conditions.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20df6b744813
Intermittent w3c-css/submitted/ui3/box-sizing-replaced-001.xht. fix skip-if ordering in reftest.list. r=gbrown
https://hg.mozilla.org/mozilla-central/rev/20df6b744813
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Depends on: 1338039
Whiteboard: [stockwell disabled]
Flags: needinfo?(aschen)
You need to log in before you can comment on or make changes to this bug.