Remove extra https:// check in WebChannel permissions check?

RESOLVED INACTIVE

Status

()

Toolkit
General
RESOLVED INACTIVE
2 years ago
2 days ago

People

(Reporter: rfkelly, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
I noticed a comment in the WebChannel code here:

  https://dxr.mozilla.org/mozilla-central/rev/cd4cdcc9ad6c45dad8b8d8c0d40e459db2bca8a1/toolkit/modules/WebChannel.jsm#176

Saying:

      // The permission manager operates on domain names rather than true
      // origins (bug 1066517).  To mitigate that, we explicitly check that
      // the scheme is https://.

Bug 1066517 has since been resolved duplicate of Bug 1165263, which is resolved fixed.  Does that mean we're not clear to remove this extra check, and depend on permission manager to do the right thing?
I believe we can, yes.

Comment 2

2 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 2 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.