Open Bug 1321718 Opened 8 years ago Updated 2 years ago

Remove extra https:// check in WebChannel permissions check?

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect

Tracking

()

People

(Reporter: rfkelly, Unassigned)

Details

I noticed a comment in the WebChannel code here:

  https://dxr.mozilla.org/mozilla-central/rev/cd4cdcc9ad6c45dad8b8d8c0d40e459db2bca8a1/toolkit/modules/WebChannel.jsm#176

Saying:

      // The permission manager operates on domain names rather than true
      // origins (bug 1066517).  To mitigate that, we explicitly check that
      // the scheme is https://.

Bug 1066517 has since been resolved duplicate of Bug 1165263, which is resolved fixed.  Does that mean we're not clear to remove this extra check, and depend on permission manager to do the right thing?
I believe we can, yes.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.