Closed Bug 1321771 Opened 3 years ago Closed 3 years ago

Remove JSAutoByteString in Intl.cpp where possible

Categories

(Core :: JavaScript: Internationalization API, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file, 1 obsolete file)

See bug 1320706 for context. And this will also avoid an additional pod_malloc.
Some Intl code are touched by bug 1319740 patch.
will finish review shortly.
See Also: → 1319740
Yes, I've read Waldo is/was going to change intl_ComputeDisplayNames [1], so my plan was to ignore that method for now. But thanks for the heads up! :-)

[1] http://logs.glob.uno/?c=mozilla%23jsapi&s=1+Dec+2016&e=1+Dec+2016#c813155
Attached patch bug1321771.patch (obsolete) — Splinter Review
Attachment #8816427 - Flags: review?(arai.unmht)
Comment on attachment 8816427 [details] [diff] [review]
bug1321771.patch

Review of attachment 8816427 [details] [diff] [review]:
-----------------------------------------------------------------

nice :)
Attachment #8816427 - Flags: review?(arai.unmht) → review+
Attached patch bug1321771.patchSplinter Review
Updated patch to place #include at correct position. Carrying r+ from Arai.
Attachment #8816427 - Attachment is obsolete: true
Attachment #8816710 - Flags: review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7beb88235a1
Replace uses of JSAutoByteString in comparisons with js::StringEqualsAscii. r=arai
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c7beb88235a1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.