1321771 - Remove JSAutoByteString in Intl.cpp where possible

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[André Bargull [:anba]]

See bug 1320706 for context. And this will also avoid an additional pod_malloc.

Comment 1

[Tooru Fujisawa [:arai]]

Some Intl code are touched by bug 1319740 patch.
will finish review shortly.

Comment 2

[André Bargull [:anba]]

Yes, I've read Waldo is/was going to change intl_ComputeDisplayNames [1], so my plan was to ignore that method for now. But thanks for the heads up! :-)

[1] http://logs.glob.uno/?c=mozilla%23jsapi&s=1+Dec+2016&e=1+Dec+2016#c813155

Comment 3

[André Bargull [:anba]]

Attachment: bug1321771.patch

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8816427 [details] [diff] [review]
bug1321771.patch

Review of attachment 8816427 [details] [diff] [review]:
-----------------------------------------------------------------

nice :)

Comment 5

[André Bargull [:anba]]

Attachment: bug1321771.patch

Updated patch to place #include at correct position. Carrying r+ from Arai.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7beb88235a1
Replace uses of JSAutoByteString in comparisons with js::StringEqualsAscii. r=arai

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c7beb88235a1