1321775 - Better checks for client property of Marionette class

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If the initial port check for Marionette in __init__ fails, @do_process_check is run and triggers a delete_session(). At this time there is no self.client defined and we fail in delete_session() with:

> AttributeError: 'Marionette' object has no attribute 'client'

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1321775 - Better handling for client property in Marionette class.

Review commit: https://reviewboard.mozilla.org/r/97170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97170/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8816418 [details]
Bug 1321775 - Better handling for client property in Marionette class.

https://reviewboard.mozilla.org/r/97170/#review97490

::: testing/marionette/client/marionette_driver/marionette.py:1313
(Diff revision 1)
>              self.session = None
>              self.process_id = None
>              self.profile = None
>              self.window = None
> +
> +            if self.client:

`if self.client is not None`

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8816418 [details]
Bug 1321775 - Better handling for client property in Marionette class.

https://reviewboard.mozilla.org/r/97170/#review97542

::: testing/marionette/client/marionette_driver/marionette.py:1313
(Diff revision 1)
>              self.session = None
>              self.process_id = None
>              self.profile = None
>              self.window = None
> +
> +            if self.client:

The client is an instance of a class and not an atomic type. So you wouldn't need that explicite check for None, because it can only be a valid instance or None.

But I will do the change to be conform with other code.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8816418 [details]
Bug 1321775 - Better handling for client property in Marionette class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97170/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23eb207c40d8
Better handling for client property in Marionette class. r=ato

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/23eb207c40d8

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Test-only change to improve the stability of Marionette. We would like to have it in the 52ESR. Please uplift to aurora. Thanks.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/46049b21980d

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.