Closed Bug 1321799 Opened 5 years ago Closed 5 years ago
Perma failures in Findbugs "Illegal format string "existence: %b, can write: %b, size: %l
." in org .mozilla .gecko .telemetry .stores .Telemetry JSONFile Ping Store .lock And Read JSONFrom File(File)"
58 bytes, text/x-review-board-request
sebastian, this seems perma failure now, can you take a look ?
Summary: Perma failures in Findbugs OSError: [Errno 2] No such file or directory → Perma failures in Findbugs "Illegal format string "existence: %b, can write: %b, size: %l." in org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadJSONFromFile(File)"
I see at least one logical error here (which my patch would fix), although I'm not sure I understand why tat would cause a crash at runtime (I've just discovered I can run findbugs locally so will test using that to see whether my patch is even useful).
Assignee: nobody → ahunt
Iteration: --- → 1.10
Priority: -- → P1
My patch appears to pacify findbugs locally, just need to wait for review now!
Comment on attachment 8816651 [details] Bug 1321799 - Use decimal format placeholder for filesize https://reviewboard.mozilla.org/r/97316/#review97818
Attachment #8816651 - Flags: review?(s.kaspari) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ff3a2aebe47d Use decimal format placeholder for filesize r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.