Closed Bug 1321799 Opened 3 years ago Closed 3 years ago

Perma failures in Findbugs "Illegal format string "existence: %b, can write: %b, size: %l." in org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadJSONFromFile(File)"

Categories

(Firefox for Android :: General, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 53
Iteration:
1.10
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ahunt)

References

Details

(Keywords: intermittent-failure, regression, Whiteboard: [MobileAS])

Attachments

(1 file)

sebastian, this seems perma failure now, can you take a look ?
Flags: needinfo?(s.kaspari)
Blocks: 1314835
Keywords: regression
Summary: Perma failures in Findbugs OSError: [Errno 2] No such file or directory → Perma failures in Findbugs "Illegal format string "existence: %b, can write: %b, size: %l." in org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.lockAndReadJSONFromFile(File)"
I see at least one logical error here (which my patch would fix), although I'm not sure I understand why tat would cause a crash at runtime (I've just discovered I can run findbugs locally so will test using that to see whether my patch is even useful).
Assignee: nobody → ahunt
Iteration: --- → 1.10
Priority: -- → P1
Whiteboard: [MobileAS]
My patch appears to pacify findbugs locally, just need to wait for review now!
Flags: needinfo?(s.kaspari)
Comment on attachment 8816651 [details]
Bug 1321799 - Use decimal format placeholder for filesize

https://reviewboard.mozilla.org/r/97316/#review97818
Attachment #8816651 - Flags: review?(s.kaspari) → review+
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff3a2aebe47d
Use decimal format placeholder for filesize r=sebastian
https://hg.mozilla.org/mozilla-central/rev/ff3a2aebe47d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.