Closed Bug 1321835 Opened 4 years ago Closed 4 years ago

Add asserts that the "given proto", if provided, is in the right compartment in bindings code

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We don't seem to assert that, and people are writing code that relies on implementation details and doesn't maintain that basic invariant.
Attachment #8816508 - Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/deadb8cb73ef
Assert that the givenProto argument for binding wrap methods is in the right compartment.  r=peterv
https://hg.mozilla.org/mozilla-central/rev/deadb8cb73ef
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.