Make Quick Search bar in AB look like Quick Search Bar in Mail

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
MailNews: Address Book & Contacts
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: jglick, Assigned: Tuukka Tolvanen (sp3000))

Tracking

Trunk
mozilla1.0
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

40.34 KB, image/gif
Details
1.25 KB, patch
Tuukka Tolvanen (sp3000)
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
Minor UI nit.
Add border around AB quick search bar to match Mail Quick Search bar.
See bug 106739.
Screenshot below.

Ben, would you be willing to fix this since you fixed bug 106739? Thanks.
(Reporter)

Comment 1

17 years ago
Created attachment 75091 [details]
Example. Make AB border look like Mail Quick Search Bar border

Comment 2

17 years ago
Hi, I'll dig up my changes to bug 106739 and see if they work for the address
book.  Unfortunately, my fix to bug 106739 ended up showing only some of the
time (bug 107571 ..never learned why), and I think bug 106739 was fixed for good
when a lot of the rest of the 3-pane was re-written.  Maybe someone should ask
Seth about it.
(Assignee)

Comment 3

17 years ago
Created attachment 75108 [details] [diff] [review]
patch

copy-paste patch */messenger/mailWindow1.css -> */messenger/addressbook.css
(Assignee)

Comment 4

17 years ago
sorry 'bout bustin' in, just happened to wander by when this was posted
Status: NEW → ASSIGNED
OS: Windows 2000 → All
(Assignee)

Comment 5

17 years ago
um. fumbling
Assignee: racham → t.bugz
Status: ASSIGNED → NEW
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED

Comment 6

17 years ago
Comment on attachment 75108 [details] [diff] [review]
patch

r=andreww providing you put the "::::: Search Bar  ::::: " comment in the
classic addressbook.css as well for consistency.
Attachment #75108 - Flags: review+
(Assignee)

Comment 7

17 years ago
Created attachment 75124 [details] [diff] [review]
patch v2

with the search bar comment in classic too
Attachment #75108 - Attachment is obsolete: true
(Assignee)

Comment 8

17 years ago
Comment on attachment 75124 [details] [diff] [review]
patch v2

carry over r=
Attachment #75124 - Flags: review+
I'll try out the patch, verify that it works, and drive it in.
Comment on attachment 75124 [details] [diff] [review]
patch v2

sr=sspitzer
Attachment #75124 - Flags: superreview+
I'll get some driver approval, and land this.

thanks for the patch, Tuukka.
Target Milestone: --- → mozilla1.0

Updated

17 years ago
Attachment #75124 - Flags: approval+

Comment 12

17 years ago
Comment on attachment 75124 [details] [diff] [review]
patch v2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
Trunk build 2002-04-01: WinMe, Linux RH 7.1, Mac 10.1.3
Verified Fixed, Classic and Modern.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.