Closed Bug 1321863 Opened 7 years ago Closed 7 years ago

Update gecko-rust-build to v0.4.0

Categories

(Taskcluster Graveyard :: Docker Images, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla53

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

Resync the rust toolchain update scripts with https://github.com/rillian/rust-build
Assignee: nobody → giles
Comment on attachment 8816528 [details]
Bug 1321863 - Update gecko-rust-build to v0.4.0.

https://reviewboard.mozilla.org/r/97244/#review97636

::: testing/docker/rust-build/Dockerfile:9
(Diff revision 1)
> -RUN yum upgrade -y
> -RUN yum clean all
> -
>  # Install tooltool directly from github.
> -RUN mkdir /builds
>  ADD https://raw.githubusercontent.com/mozilla/build-tooltool/master/tooltool.py /build/tooltool.py

Not necessarily in this bug, but it would be great to use the vendored copy of tooltool.py instead:

https://dxr.mozilla.org/mozilla-central/source/testing/docker/desktop-build/Dockerfile#14

so something like
    # %include testing/docker/recipes/tooltool.py
    ADD topsrcdir/testing/docker/recipes/tooltool.py /build/tooltool.py
Attachment #8816528 - Flags: review?(dustin) → review+
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9658fd731f0
Update gecko-rust-build to v0.4.0. r=dustin
Comment on attachment 8816528 [details]
Bug 1321863 - Update gecko-rust-build to v0.4.0.

https://reviewboard.mozilla.org/r/97244/#review97662

::: testing/docker/rust-build/Dockerfile:9
(Diff revision 1)
> -RUN yum upgrade -y
> -RUN yum clean all
> -
>  # Install tooltool directly from github.
> -RUN mkdir /builds
>  ADD https://raw.githubusercontent.com/mozilla/build-tooltool/master/tooltool.py /build/tooltool.py

Thanks for the reminder. This means it doesn't work with the normal docker cli though. Have you had any luck upstreaming this extension?
https://hg.mozilla.org/mozilla-central/rev/d9658fd731f0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
good question -- :gps is the person to ask
Flags: needinfo?(gps)
No, we haven't even tried to upstream this extension.
Flags: needinfo?(gps)
:giles, another option may be to copy tooltool.py into that Dockerfile directory, and add a comment to the Dockerfile that it should match the vendored copy.  We'd like to avoid automation hitting github.com as a rule (of course this is very much a corner case!).
Product: Taskcluster → Taskcluster Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: