1321863 - Update gecko-rust-build to v0.4.0

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, defect)

Description

[Ralph Giles (:rillian)]

Resync the rust toolchain update scripts with https://github.com/rillian/rust-build

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1321863 - Update gecko-rust-build to v0.4.0.

Sync with upstream. Have been using the repack script for
that last few updates.

- New splat_rust.py script to update gecko tooltool manifests.
- Drop cargo nightly repacks in favor of stable cargo.
- Build with linux32 to i586.
- Switch linux32 back to i686 in repacks.
- Add android-x86.

Review commit: https://reviewboard.mozilla.org/r/97244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97244/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8816528 [details]
Bug 1321863 - Update gecko-rust-build to v0.4.0.

https://reviewboard.mozilla.org/r/97244/#review97636

::: testing/docker/rust-build/Dockerfile:9
(Diff revision 1)
> -RUN yum upgrade -y
> -RUN yum clean all
> -
>  # Install tooltool directly from github.
> -RUN mkdir /builds
>  ADD https://raw.githubusercontent.com/mozilla/build-tooltool/master/tooltool.py /build/tooltool.py

Not necessarily in this bug, but it would be great to use the vendored copy of tooltool.py instead:

https://dxr.mozilla.org/mozilla-central/source/testing/docker/desktop-build/Dockerfile#14

so something like
    # %include testing/docker/recipes/tooltool.py
    ADD topsrcdir/testing/docker/recipes/tooltool.py /build/tooltool.py

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9658fd731f0
Update gecko-rust-build to v0.4.0. r=dustin

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8816528 [details]
Bug 1321863 - Update gecko-rust-build to v0.4.0.

https://reviewboard.mozilla.org/r/97244/#review97662

::: testing/docker/rust-build/Dockerfile:9
(Diff revision 1)
> -RUN yum upgrade -y
> -RUN yum clean all
> -
>  # Install tooltool directly from github.
> -RUN mkdir /builds
>  ADD https://raw.githubusercontent.com/mozilla/build-tooltool/master/tooltool.py /build/tooltool.py

Thanks for the reminder. This means it doesn't work with the normal docker cli though. Have you had any luck upstreaming this extension?

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9658fd731f0

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

good question -- :gps is the person to ask

Comment 7

[Gregory Szorc [:gps]]

No, we haven't even tried to upstream this extension.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

:giles, another option may be to copy tooltool.py into that Dockerfile directory, and add a comment to the Dockerfile that it should match the vendored copy.  We'd like to avoid automation hitting github.com as a rule (of course this is very much a corner case!).