1321884 - helper threads leak the HeldMutexStack

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Trevor Saunders (:tbsaunde)]

the HeldMutexStack is thread local so it needs to be cleaned up on all threads that use it, not just the main thread.

I found this in SpiderNode, but can reproduce it with valgrind and a debug build of the standard js shell.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: clean up the HeldMutexStack on helper threads

The HeldMutexStack is cleaned up in JS_ShutDown() on the main thread, but since
it is thread local we need to clean it up on other threads where it is used.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8816565 [details] [diff] [review]
clean up the HeldMutexStack on helper threads

Review of attachment 8816565 [details] [diff] [review]:
-----------------------------------------------------------------

Ah yes, we do.  Thanks for the fix!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ec6d1a356d1
clean up the HeldMutexStack on helper threads r=jonco

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ec6d1a356d1