Closed Bug 1321884 Opened 3 years ago Closed 3 years ago

helper threads leak the HeldMutexStack

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

the HeldMutexStack is thread local so it needs to be cleaned up on all threads that use it, not just the main thread.

I found this in SpiderNode, but can reproduce it with valgrind and a debug build of the standard js shell.
The HeldMutexStack is cleaned up in JS_ShutDown() on the main thread, but since
it is thread local we need to clean it up on other threads where it is used.
Attachment #8816565 - Flags: review?(jcoppeard)
Assignee: nobody → tbsaunde+mozbugs
Comment on attachment 8816565 [details] [diff] [review]
clean up the HeldMutexStack on helper threads

Review of attachment 8816565 [details] [diff] [review]:
-----------------------------------------------------------------

Ah yes, we do.  Thanks for the fix!
Attachment #8816565 - Flags: review?(jcoppeard) → review+
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ec6d1a356d1
clean up the HeldMutexStack on helper threads r=jonco
https://hg.mozilla.org/mozilla-central/rev/8ec6d1a356d1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.