helper threads leak the HeldMutexStack

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
the HeldMutexStack is thread local so it needs to be cleaned up on all threads that use it, not just the main thread.

I found this in SpiderNode, but can reproduce it with valgrind and a debug build of the standard js shell.
(Assignee)

Comment 1

2 years ago
Created attachment 8816565 [details] [diff] [review]
clean up the HeldMutexStack on helper threads

The HeldMutexStack is cleaned up in JS_ShutDown() on the main thread, but since
it is thread local we need to clean it up on other threads where it is used.
Attachment #8816565 - Flags: review?(jcoppeard)
Assignee: nobody → tbsaunde+mozbugs
Comment on attachment 8816565 [details] [diff] [review]
clean up the HeldMutexStack on helper threads

Review of attachment 8816565 [details] [diff] [review]:
-----------------------------------------------------------------

Ah yes, we do.  Thanks for the fix!
Attachment #8816565 - Flags: review?(jcoppeard) → review+

Comment 3

2 years ago
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ec6d1a356d1
clean up the HeldMutexStack on helper threads r=jonco

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8ec6d1a356d1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.