Closed
Bug 1321884
Opened 8 years ago
Closed 8 years ago
helper threads leak the HeldMutexStack
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(1 file)
|
976 bytes,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
the HeldMutexStack is thread local so it needs to be cleaned up on all threads that use it, not just the main thread. I found this in SpiderNode, but can reproduce it with valgrind and a debug build of the standard js shell.
|
Assignee | |
Comment 1•8 years ago
|
||
The HeldMutexStack is cleaned up in JS_ShutDown() on the main thread, but since it is thread local we need to clean it up on other threads where it is used.
Attachment #8816565 -
Flags: review?(jcoppeard)
|
||
Updated•8 years ago
|
Assignee: nobody → tbsaunde+mozbugs
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8816565 [details] [diff] [review] clean up the HeldMutexStack on helper threads Review of attachment 8816565 [details] [diff] [review]: ----------------------------------------------------------------- Ah yes, we do. Thanks for the fix!
Attachment #8816565 -
Flags: review?(jcoppeard) → review+
Pushed by tsaunders@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8ec6d1a356d1 clean up the HeldMutexStack on helper threads r=jonco
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8ec6d1a356d1
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•