Closed
Bug 1321886
Opened 8 years ago
Closed 8 years ago
Pinging broken due to bug 1302447
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 53
People
(Reporter: clokep, Assigned: freaktechnik)
References
Details
Attachments
(1 file)
|
3.24 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
Users can't be pinged in IRC channels due to a regression from bug 1302447.
|
Assignee | |
Comment 1•8 years ago
|
||
The tag handling patch broke pinging in MUCs for IRC, as it did not call the correct writeMessage for MUCs. This patch moves the tag handling into e separate method that gets called by the writeMessage implementations of each of the two conversation types.
Attachment #8816574 -
Flags: review?(clokep)
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8816574 [details] [diff] [review] fix-no-highlights-v1.patch Review of attachment 8816574 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8816574 -
Flags: review?(clokep) → review+
|
|
Reporter | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/574783e7c0ffed1db41540fe93b819065ba3cfac
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 53
You need to log in
before you can comment on or make changes to this bug.
Description
•