Closed Bug 1321891 Opened 8 years ago Closed 7 years ago

Baldr: update .name of exported wasm functions

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(1 file)

Attached patch fix-func-nameSplinter Review
Attachment #8821225 - Flags: review?(bbouvier)
Comment on attachment 8821225 [details] [diff] [review]
fix-func-name

Review of attachment 8821225 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8821225 - Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d98d1548d5dd
Baldr: update .name of exported wasm functions (r=bbouvier)
Comment on attachment 8821225 [details] [diff] [review]
fix-func-name

Approval Request Comment
[Feature/Bug causing the regression]: spec change/refinement, not a bug
[User impact if declined]: incorrect behavior that is more noticeable
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: tiny patch
Attachment #8821225 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d98d1548d5dd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8821225 [details] [diff] [review]
fix-func-name

Small change in wasm spec - ok to uplift to aurora.
Attachment #8821225 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
See Also: → 1714505
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: