1321894 - embed.views:ResultsetStatusView.get "AttributeError: 'long' object has no attribute 'get_status'"

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, defect, P1)

Description

[Ed Morley [:emorley]]

Started occurring as of today's prod deploy:

https://rpm.newrelic.com/accounts/677903/applications/14179757/filterable_errors#/show/a29e661c-b8d6-11e6-9c7c-b82a72d22a14_0_4172/stack_trace?top_facet=transactionUiName&primary_facet=error.class&barchart=barchart&_k=z002dy

File "/app/treeherder/embed/views.py", line 24, in get_context_data
exceptions:AttributeError: 'long' object has no attribute 'get_status'

On:
https://treeherder.mozilla.org/embed/resultset-status/try/697ea1e0c992/

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1321894 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8817751 [details] [review]
[treeherder] wlach:1321894 > mozilla:master

Argh, this is the second time this endpoint broke as a result of my refactoring. I added a very simple unit test which should at least catch these sorts of simple failure cases.

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2c32fc8b62385ee050683812fb431936854f39e1
Bug 1321894 - Embed css directly in resultset_status html

There's not really any need to put such a small amount of CSS in its own
file. This was also the easiest route to making the unit tests (which
aren't wired up to pull static assets) work.

https://github.com/mozilla/treeherder/commit/3ac4a9ec59656ba31fd5ce5c9323e29633986bd5
Bug 1321894 - Fix embedded resultset view and add a unit test for it