Remove the appId field from the moz_cookies table

RESOLVED FIXED in Firefox 53

Status

()

Core
Networking: Cookies
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [necko-would-take])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Once bug 1320402 is fixed, there is no reason to keep the appId field in the cookies database any more.

Note that bug 1165267 (shipped in Firefox 44) removed the appId field from the downgrade query <http://searchfox.org/mozilla-central/source/netwerk/cookie/nsCookieService.cpp#1360>, and it also removed it from the SELECT and INSERT INTO queries.  This means that removing the appId field should have no impact over downgrading the profile, which is great!
Whiteboard: [necko-would-take]
(Assignee)

Comment 1

2 years ago
Created attachment 8819324 [details] [diff] [review]
Remove the appId field from the moz_cookies table

I'm planning to land this after bug 1320402 lands, so I will need to rebase it on top of the cookie migration pass implemented there, but nothing else should change substantially, so this should be ready to review.
Attachment #8819324 - Flags: review?(josh)

Updated

2 years ago
Attachment #8819324 - Flags: review?(josh) → review+

Comment 2

2 years ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e1c9517001b
Remove the appId field from the moz_cookies table; r=jdm

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6e1c9517001b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
A couple questions:

1) If I interpret comment 0 right, we can downgrade cookie DBs safely back to Firefox 44, and that's good enough.  Right?

2) Any reason we didn't also get rid of the 'inBrowserElement' field?  AFAICT that's also now unused.
Flags: needinfo?(josh)
1) Yes.
2) I guess not.
Flags: needinfo?(josh)
You need to log in before you can comment on or make changes to this bug.