Remove E129 from flake8 lint

RESOLVED FIXED in Firefox 53

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: jgraham, Unassigned)

Tracking

unspecified
mozilla53

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

3 years ago
This is the one that claims

if (foo and
    bar):
    baz

is a bad idea, when it's clearly better than the alternatives.

Comment 2

3 years ago
mozreview-review
Comment on attachment 8816674 [details]
Bug 1321956 - Disable flake8 check for 'visually indented line with same indent as next logical line',

https://reviewboard.mozilla.org/r/97326/#review98048

Lgtm.. I was debating if we should discuss this in the mailing list or not first, but meh. I doubt anyone would care, and if they do we can always re-enable and add a specific .flake8 config for mozbase to disable it there.
Attachment #8816674 - Flags: review?(ahalberstadt) → review+

Comment 3

3 years ago
mozreview-review
Comment on attachment 8816674 [details]
Bug 1321956 - Disable flake8 check for 'visually indented line with same indent as next logical line',

https://reviewboard.mozilla.org/r/97326/#review98052

::: layout/generic/crashtests/crashtests.list:632
(Diff revision 1)
>  load text-overflow-bug713610.html
>  load text-overflow-form-elements.html
>  load text-overflow-iframe.html
>  asserts-if(Android,2-4) asserts-if(!Android,4) load 1225005.html # bug 682647 and bug 448083
>  load 1233191.html
> -skip-if(Android) asserts(3) load 1271765.html
> +asserts(3) load 1271765.html

I think these assertion changes slipped in by accident.

Comment 4

3 years ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0dae693fdbc
Disable flake8 check for 'visually indented line with same indent as next logical line', r=ahal

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b0dae693fdbc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

Last year
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.