Closed
Bug 1321956
Opened 7 years ago
Closed 7 years ago
Remove E129 from flake8 lint
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jgraham, Unassigned)
Details
Attachments
(1 file)
This is the one that claims if (foo and bar): baz is a bad idea, when it's clearly better than the alternatives.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8816674 [details] Bug 1321956 - Disable flake8 check for 'visually indented line with same indent as next logical line', https://reviewboard.mozilla.org/r/97326/#review98048 Lgtm.. I was debating if we should discuss this in the mailing list or not first, but meh. I doubt anyone would care, and if they do we can always re-enable and add a specific .flake8 config for mozbase to disable it there.
Attachment #8816674 -
Flags: review?(ahalberstadt) → review+
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8816674 [details] Bug 1321956 - Disable flake8 check for 'visually indented line with same indent as next logical line', https://reviewboard.mozilla.org/r/97326/#review98052 ::: layout/generic/crashtests/crashtests.list:632 (Diff revision 1) > load text-overflow-bug713610.html > load text-overflow-form-elements.html > load text-overflow-iframe.html > asserts-if(Android,2-4) asserts-if(!Android,4) load 1225005.html # bug 682647 and bug 448083 > load 1233191.html > -skip-if(Android) asserts(3) load 1271765.html > +asserts(3) load 1271765.html I think these assertion changes slipped in by accident.
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/b0dae693fdbc Disable flake8 check for 'visually indented line with same indent as next logical line', r=ahal
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b0dae693fdbc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Product: Testing → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•