1321986 - Improve button icons in firebug theme

Status: RESOLVED INVALID

(DevTools :: General, defect, P3)

Description

[Ruturaj Vartak]

Attachment: firebug-icons.png

The button icons in firebug theme aren't as clear and consistent as the light and dark theme icons.

Check the comparative screen-shot attached

Comment 1

[Ruturaj Vartak]

Tim ?

Comment 2

[Tim Nguyen :ntim]

I'll defer this to Honza.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

What's exactly is wrong with the icons? Is there anything specific you'd like to change? All Icons or just some of them?

Sebastian created these icons so, I am also NI him here.

Honza

Comment 4

[Ruturaj Vartak]

Sorry for the vague bug, but here are my observations referring to attachment#8816701 [details]

These seem ok
- The open-close, switch-off, Docking icons are fine (in line with firebug2's theme)
- Show Console - seems OK (again from original Fb2 theme)

These are off
- The window frame icon has blue and white color filled in
- Responsive Design Mode icon - this has dark gray filled color
- Ruler icon - has got white color filled.
- Options icon (cog) has got a gray gradient filled in. Its also positioned slightly below the center line


If we compare the same with the light or dark theme
- all icons are consistent
- No color filled in
- Same width lines
- Easily identifiable: Shape-design-color consistency leads to easy differentiation.

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Jan Honza Odvarko [:Honza] (PTO: 12/09-01/01) from comment #3)
> Sebastian created these icons so, I am also NI him here.

I can see that most of them are somewhat blurry. I may try to improve their display, though while I created them, I'm not a graphics designer. I'd prefer if someone with experience in that area took this over.

Sebastian

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to Ruturaj Vartak from comment #4)
> These are off
> - The window frame icon has blue and white color filled in
> - Responsive Design Mode icon - this has dark gray filled color
> - Ruler icon - has got white color filled.
> - Options icon (cog) has got a gray gradient filled in. Its also positioned
> slightly below the center line

Also the icons for some more tools are off (blurry):
- Highlight painted area
- Scratchpad
- Take a screenshot of the entire page
- Measure a portion of the page

Sebastian

Comment 7

[Ruturaj Vartak]

Can we use the default (light and dark theme) icons ?
Or may be Helen can help into.

Comment 8

[Sebastian Zartner [:sebo]]

As the Firebug theme got removed in Firefox 61 (see bug 1378108), this bug isn't actionable anymore.

Sebastian