1321994 - thunderbird version 51 beta repacks fail reading checksums file

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1317863 +++

per Joe ...

From our current build at
http://ftp.mozilla.org/pub/thunderbird/candidates/51.0b1-candidates/build2/logs/release-comm-beta-linux_repack_10-bm72-build1-build18.txt.gz
Not sure of the significance of this error, but certainly different from the
last errors.

InsecurePlatformWarning
Caught HTTPError: ["Couldn't find locale identified by:
Thunderbird-51.0b1-build2, Linux_x86-gcc3, zh-TW"]
The following tracebacks were detected during repacks:
zh-CN:
Traceback (most recent call last):
  File
"/builds/slave/tb-rel-c-beta-lx_rpk_10-000000/scripts/scripts/l10n/create-release-repacks.py",
line 146, in createRepacks
    checksums = parseChecksumsFile(open(checksums_file).read())
IOError: [Errno 2] No such file or directory:
'/builds/slave/tb-rel-c-beta-lx_rpk_10-000000/comm-beta/obj-l10n/mail/locales/dist/linux-i686/zh-CN/thunderbird-51.0b1.checksums'


and later

command: output:
Missing searchplugin: eBay.xml
'../../dist/linux-x86_64/br//thunderbird-51.0b1.checksums'

Traceback (most recent call last):
  File "/builds/slave/tb-rel-c-beta-l64_rpk_1-000000/scripts/scripts/l10n/create-release-repacks.py", line 146, in createRepacks
    checksums = parseChecksumsFile(open(checksums_file).read())
IOError: [Errno 2] No such file or directory: '/builds/slave/tb-rel-c-beta-l64_rpk_1-000000/comm-beta/obj-l10n/mail/locales/dist/linux-x86_64/br/thunderbird-51.0b1.checksums'

Comment 1

[Magnus Melin [:mkmelin]]

Re eBay.xml - bug 1303636, that file shouldn't exist anymore.

Comment 2

[aleth [:aleth]]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #0)
> line 146, in createRepacks
>     checksums = parseChecksumsFile(open(checksums_file).read())
> IOError: [Errno 2] No such file or directory:
> '/builds/slave/tb-rel-c-beta-lx_rpk_10-000000/comm-beta/obj-l10n/mail/
> locales/dist/linux-i686/zh-CN/thunderbird-51.0b1.checksums'

This path should be /builds/slave/tb-rel-c-beta-lx_rpk_10-000000/comm-beta/obj-l10n/dist/linux-i686/zh-CN/thunderbird-51.0b1.checksums, so somewhere the ../.. is getting lost.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Possible Fix - v1

It looks to me like the cwd changed from where the locales repack script is running, otherwise I can't explain why this was working in the first place.

This patch would make sure that the make command is run from the expected directory, but the actual problem may be somewhere else. I think it is worth a try though.

FYI, localeSrcDir is actually comm-beta/objdir-tb/mail/locales, not comm-beta/mail/locales as I would have assumed from the variable name.

Comment 4

[aleth [:aleth]]

(In reply to Philipp Kewisch [:Fallen] from comment #3)
> otherwise I can't explain why this was working in the first place.

The command output printed in the logs (and so relative_checksums) is ../../dist/linux-i686/tr//thunderbird-51.0b1.checksums, which joined to localeSrcDir (comm-beta/obj-l10n/mail/locales) would actually be correct. So I'm actually not sure what's going wrong here (but setting the cwd is worth a try).

Comment 5

[aleth [:aleth]]

(In reply to Philipp Kewisch [:Fallen] from comment #3)
> This patch would make sure that the make command is run from the expected
> directory, but the actual problem may be somewhere else. I think it is worth
> a try though.

Hmm, setting the cwd was previously removed here: https://hg.mozilla.org/build/tools/rev/457930323760#l1.70
It's not immediately apparent from the bug why.

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8816735 [details] [diff] [review]
Possible Fix - v1

Review of attachment 8816735 [details] [diff] [review]:
-----------------------------------------------------------------

so I think it's okay to try this but I'm missing the connection on how it will help.

fwiw - in mozharness desktop ff world, we run something like this:
'make echo-variable-UPLOAD_FILES echo-variable-CHECKSUM_FILES AB_CD=gn'] in /builds/slave/rel-m-beta_fx_l64_l10n_rpk-000/build/mozilla-beta/obj-l10n/browser/locales

which, iiuc, after the relative path eval, this should be the mail equivalent.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8816735 [details] [diff] [review]
Possible Fix - v1

Ok, it seems I was using tunnel vision when writing that patch, the chdir should indeed catch things. 

We are going to go with fixing the searchplugins issue first, maybe that will already help enough to get the builds running. The issue there was missing sign-offs on beta, which I have taken care of.

Given the ../.. was stripped off somewhere there is still a chance this may fail. I'm kind of puzzled, because the output suggets the make echo-variable seems to be displaying the right thing, which is just passed to join+normpath, which then fails. One of those variables must be wrong, but the localeSrcDir seems right because the command is executed in the right directory, and the relative path seems to be right because the output is correct.

Comment 8

[aleth [:aleth]]

It turned out this was actually due to l1on signoff issues.