Closed Bug 1321995 Opened 3 years ago Closed 11 months ago

Support high DPI scaling for the crash reporter

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: itiel_yn8, Assigned: emk)

References

()

Details

Attachments

(5 files)

Currently when Firefox crashes, the crash reporter's text is blurry on screen resolution set to a high DPI scaling.

Attached screenshot of the crash reporter on a 24" monitor, 1920x1080 with 150% DPI scaling.
Same goes for errors related to the crash reporter.
Component: General → Graphics: Text
Product: Firefox → Core
Component: Graphics: Text → Breakpad Integration
Product: Core → Toolkit
Duplicate of this bug: 1338136
Gabriele suggests he knows something about this code, so maybe he can suggest how we can fix this? Now that most of Firefox' primary UI is hidpi friendly, and an increasing number of Windows laptops/tablets/multi-modal devices support hidpi, this is becoming more obvious. :-)

(for background on Windows and hidpi, if required, I'd suggest asking :jfkthame.)

(Also CC'ing Ted because he's hemming and hawing over how much of this he still owns. ;-) )
Flags: needinfo?(gsvelto)
I'll have a look; I've mucked around with this code lately and I don't think it should be too hard.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Flags: needinfo?(gsvelto)
I've done my little research and as it turns out to enable proper support in Windows 10 this is non-trivial work. I don't mind doing it but I've got more urgent things to work on so it might take me some time.
The new "GDI scaling" option in Creators Update will improve the scaling behavior almost free.
This is strict improvement until we have a proper per-monitor DPI support.
Attachment #8835987 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8835987 [details] [diff] [review]
Enable Creators Update's GDI Scaling on the crash reporter

I'm not comfortable reviewing this, unfortunately. Jim or Jonathan will know more, I expect.
Attachment #8835987 - Flags: review?(jmathies)
Attachment #8835987 - Flags: review?(jfkthame)
Attachment #8835987 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8835987 [details] [diff] [review]
Enable Creators Update's GDI Scaling on the crash reporter

Review of attachment 8835987 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tested the dialog interface to see what impact this has on the layout?
Attachment #8835987 - Flags: review?(jmathies) → review+
Test result for the record.
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62d185454bf6
Enable Creators Update's GDI Scaling on the crash reporter. r=jimm
This is not the final fix.
Keywords: leave-open
Comment on attachment 8835987 [details] [diff] [review]
Enable Creators Update's GDI Scaling on the crash reporter

Somewhat belated r+ from me, too. And thanks for posting the screenshots, :emk, I was going to ask for those. :)
Attachment #8835987 - Flags: review?(jfkthame) → review+
Unassigning myself since I don't have time to write the proper fix for this ATM. I'll pick it up at a later time.
Assignee: gsvelto → nobody
Status: ASSIGNED → NEW
Looking good on Windows 10 build 1709. Does anyone know if this is fixed also on earlier builds?
The leave-open keyword is there and there is no activity for 6 months.
:kentuckyfriedtakahe, maybe it's time to close this bug?
Flags: needinfo?(ajones)
We might want to close this bug and open another one for proper support of high DPI functionality.

(In reply to Gabriele Svelto [:gsvelto] from comment #21)

We might want to close this bug and open another one for proper support of
high DPI functionality.

Gabriele - can I ask you to do that?

Flags: needinfo?(ajones) → needinfo?(gsvelto)

Filed bug 1521450 for full-fledged hi-DPI support. Closing this one.

Status: NEW → RESOLVED
Closed: 11 months ago
Flags: needinfo?(gsvelto)
Resolution: --- → FIXED
Assignee: nobody → VYV03354
You need to log in before you can comment on or make changes to this bug.