1322059 - icons missing from menus

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, defect)

Description

[sarosto]

in Nightly 53, the icons are missing from the menus (including in the traditional menubar as well as the context menus). e.g., if you right click in a page, you'll have a "Save Page As..." option -- in Firefox 50 (at least), there's an icon to the left of the text, whereas in Nightly 53, there's no icon.

this issue affects linux (not sure about other platforms).

the icons are useful for more quickly identifying the menu item you're looking for.

Comment 1

[[:Towkir] Ahmed]

Can you attach a screenshot ?

Comment 2

[sarosto]

Attachment: comparison between Firefox 50 (left) and Nightly 53 (right)

Comment 3

[Loic]

It looks like a regression in 53 (or 52) with the Linux version (I don't have icons on Windows).

sarosto, could you use the tool mozregression to narrow down a regression in 53 (or 52/51).
See http://mozilla.github.io/mozregression/ for details.

Run the command "mozregression --good=50" then copy here the final pushlog from the repository mozilla-inbound.

Comment 4

[sarosto]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e53b60b53d496a7ebae57643e8adda64b7b6bacb&tochange=e7680c5fead3325a37924862967322c080b74ee7

Comment 5

[Loic]

So it's expected by design, they removed icons for some reasons, now it's in parity with the other platforms.

Comment 6

[Jonathan Kingston [:jkt] he/him]

The reasons were: 
- Parity of platforms
- The GTK feature (-moz-images-in-menus) that enables those icons is also deprecated
- The GTK feature was causing other issues with container icons.
Sorry; the likelyhood is when the new theming changes happens creating a OS specific theme will be much easier.