Reps with a more link shows -3 more...

VERIFIED FIXED in Firefox 53

Status

VERIFIED FIXED
2 years ago
2 months ago

People

(Reporter: ntim, Assigned: nchevobbe)

Tracking

unspecified
Firefox 53

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8816838 [details]
Screenshot

It would be nice if we had a test that caught this.
(Assignee)

Comment 1

2 years ago
Thanks for reporting this Tim.

We dealt with similar thing in Bug 1305981, and we added some tests there.
The problem is that it heavily depends on what's in the packet, and can't be easily testable before we know what the packet have or do not have.
Here, it seems that the applicationCache object does not have any "object length" property we're looking for in the Rep.
What's weird is that the applicationCache object in the DOM Panel only show the class name in v50. Something must have changed because we show the internals now.

I'll look for that change and will find a way to display this correctly.

We can find a way to test all the window properties and make sure that if they do show a "more..." label, it is > 0. But at first glance I'm afraid it might take quite some time (there's more than 250 properties on the window object).
Assignee: nobody → chevobbe.nicolas
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8819655 [details]
Bug 1322083 - Fix Reps with safeGetterValues;

https://reviewboard.mozilla.org/r/99352/#review99624

Works great, thanks! r+ if try is green.
Attachment #8819655 - Flags: review?(ntim.bugs) → review+

Comment 5

2 years ago
Pushed by chevobbe.nicolas@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/114273f3f712
Fix Reps with safeGetterValues; r=ntim

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/114273f3f712
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 7

2 years ago
I have reproduced this bug with Nightly 53.0a1 (2016-12-04) (32-bit) on Windows 8.1 (64-bit)

This bug's fix is verified on Latest Nightly 53.0a1 (2016-12-28) (32-bit).

Build ID : 20161228030213
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20161228]

Comment 8

2 years ago
The bug is verified on Mozilla Nighty version. [bugday-20160104]
(Reporter)

Updated

2 years ago
Status: RESOLVED → VERIFIED

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.