13221 - Comments starting with dashes are not handled properly

Status: CLOSED INVALID

(Core :: XML, defect, P3)

Description

[rbs]

1/ Given the simplified test case document:

<?xml version="1.0"?>
<!--
  -- comment
  -->
<para>
</para>

The parser reports:

 XML Parsing Error: not well-formed Line Number 3, Column 4:
  -- comment
 ----^

2/ Given the modified test case document:
<?xml version="1.0"?>
<!--
  ** comment
  -->
<para>
</para>

The parser reports _no_ error. In other words, comment
lines starting with dashes are confusing to the parser.

3/ Given an empty document
<?xml version="1.0"?>
<!--
  ** comment
  -->

The parser reports an error: No element found.
(I am not sure if empty documents are not allowed in XML, and if therefore
the parser is in compliance with the XML REC which is pretty strict).

Comment 1

[Nisheeth Ranjan]

Accepting bug and setting milestone to M15

Comment 2

[Hixie (not reading bugmail)]

Hmm, no bug here. The string "--" is not allowed in an XML comment, so the
parser is 100% correct in saying that the first document is "not well formed".
See XML spec, section 2.5.
Marking INVALID.

Comment 3

[rbs]

Right. Verified Sec 2.5 of the XML REC and saw the following
excerpt "For compatibility, the string "--" (double-hyphen)  must
not occur within comments."

What about point 3/. Are empty documents allowed or not allow in XML?

Comment 4

[Nisheeth Ranjan]

All XML documents have to be well formed.  So, I think the following would be
the equivalent of an "empty" XML document:

<?xml version="1.0" ?>
<!DOCTYPE foo>
<foo></foo>

Comment 5

[rbs]

Verified. In Sec 2-2.1 of the XML REC, it is indeed mentioned that
all XML document must contain at least one element (which may possibly
be an empty <element/>) in order to be considered well-formed.

Making bug as closed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7de2f62f6f61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13221 - Update global ETP to include PBM