Closed Bug 1322119 Opened 7 years ago Closed 7 years ago

RTL support for progress bar

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P3)

All
Android
defect

Tracking

(firefox53 verified)

VERIFIED FIXED
Firefox 53
Tracking Status
firefox53 --- verified

People

(Reporter: itiel_yn8, Assigned: maliu)

References

Details

(Keywords: rtl)

Attachments

(3 files)

Attached image LTR'd progress bar
On (most of the) current phones running the latest RTL Nightly build, the progress bar starts at the left and ends at the right.
RTL builds should have the progress bar start at the right and end at the left.
According to bug 928663 comment 21, only one device (out of 6 tested) has the progress bar RTL'd.

Attached current look of the progress bar on latest Nightly build (53.0a1 2016-12-04), Hebrew, Samsung Galaxy S5 Android 6.0.1.
Priority: -- → P3
Fallback solution to put mirrored drawable to correct resource folder "ldrtl". See Bug 1323763.
Assignee: nobody → max
Depends on: 1323763
tracking-fennec: --- → ?
tracking-fennec: ? → ---
Seems to be fixed in latest Nightly on Samsung Galaxy S5 G900F Android 6.0.1.

Sorina, can you please verify this is fixed in all of your devices? Thanks!
Flags: needinfo?(sorina.florean)
Comment on attachment 8823245 [details]
Bug 1322119 - Put mirrored 9patch drawable into ldrtl resource folder,

https://reviewboard.mozilla.org/r/101812/#review102490
Attachment #8823245 - Flags: review?(s.kaspari) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8eb9f5ade3df
Put mirrored 9patch drawable into ldrtl resource folder, r=sebastian
Keywords: checkin-needed
Tested on AR build 53.0a1 (2017-01-04) with devices:
- Nexus 9 (Android 7.0)
- Nexus 5 (Android 6.0.1)
- LG G4 (Android 5.1)
- Lenovo A536 (Android 4.4.2)
The issue is fixed, the progress bar start at the right.
Flags: needinfo?(sorina.florean)
https://hg.mozilla.org/mozilla-central/rev/8eb9f5ade3df
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Attached image Progress Bar
AR Fennec 53.0a1 2017-01-17 Pixel Android 7.1.1
This is verified fixed on AR Fennec 53.0a1 2017-01-17 Pixel Android 7.1.1
Status: RESOLVED → VERIFIED
Hardware: Unspecified → All
Version: unspecified → Trunk
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.