RTL support for progress bar

VERIFIED FIXED in Firefox 53

Status

()

Firefox for Android
Theme and Visual Design
P3
normal
VERIFIED FIXED
8 months ago
6 months ago

People

(Reporter: ItielMaN, Assigned: maliu)

Tracking

(Blocks: 1 bug, {rtl})

Trunk
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

8 months ago
Created attachment 8816876 [details]
LTR'd progress bar

On (most of the) current phones running the latest RTL Nightly build, the progress bar starts at the left and ends at the right.
RTL builds should have the progress bar start at the right and end at the left.
According to bug 928663 comment 21, only one device (out of 6 tested) has the progress bar RTL'd.

Attached current look of the progress bar on latest Nightly build (53.0a1 2016-12-04), Hebrew, Samsung Galaxy S5 Android 6.0.1.
(Reporter)

Updated

8 months ago
Priority: -- → P3
(Assignee)

Comment 1

7 months ago
Fallback solution to put mirrored drawable to correct resource folder "ldrtl". See Bug 1323763.
Assignee: nobody → max
Depends on: 1323763
tracking-fennec: --- → ?
tracking-fennec: ? → ---
Blocks: 1319302
(Reporter)

Comment 2

7 months ago
Seems to be fixed in latest Nightly on Samsung Galaxy S5 G900F Android 6.0.1.

Sorina, can you please verify this is fixed in all of your devices? Thanks!
Flags: needinfo?(sorina.florean)
Comment hidden (mozreview-request)

Comment 4

7 months ago
mozreview-review
Comment on attachment 8823245 [details]
Bug 1322119 - Put mirrored 9patch drawable into ldrtl resource folder,

https://reviewboard.mozilla.org/r/101812/#review102490
Attachment #8823245 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 5

7 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8eb9f5ade3df
Put mirrored 9patch drawable into ldrtl resource folder, r=sebastian
Keywords: checkin-needed
Tested on AR build 53.0a1 (2017-01-04) with devices:
- Nexus 9 (Android 7.0)
- Nexus 5 (Android 6.0.1)
- LG G4 (Android 5.1)
- Lenovo A536 (Android 4.4.2)
The issue is fixed, the progress bar start at the right.
Flags: needinfo?(sorina.florean)

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8eb9f5ade3df
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 8

6 months ago
Created attachment 8827979 [details]
Progress Bar

AR Fennec 53.0a1 2017-01-17 Pixel Android 7.1.1

Comment 9

6 months ago
This is verified fixed on AR Fennec 53.0a1 2017-01-17 Pixel Android 7.1.1
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
Hardware: Unspecified → All
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.