1322121 - [Regression] Bookmarks are not displayed after session restore

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build 6.0b6
Device iPad Air 2
iOS 10.1.1

Steps to reproduce:
1. Open a new tab and tap on the bookmark panel 
2. Open a new tab and go to youtube.com
3. Close Firefox 
4. Restore Firefox
5. Go to tab that was opened in the bookmark panel 

Actual results:
- Bookmarks are not displayed.

Expected results: 
- Bookmarks should be displayed.

See video: https://www.youtube.com/watch?v=Cc661Z0GmO4

Comment 1

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 2

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/431ba65ee8997d906e711a6c04a6a0eccb89f06f

Comment 3

[Stephan Leroux [:sleroux]]

v6.x 8e2037b9d7e62b8abd6b135985d8006cac1c2dfd

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on master 6dae35c6.

Comment 5

[Simon Basca [:SimonB]]

Hello,

For some reason when I tested this issue on 6dae35c6 I was unable to reproduce it. When I have re-tested this issue I was able to reproduce it on latest Nightly fdbfbcbc and also on 6.0b7. 

Farhan, do you have any ideas what's happening?

Comment 6

[Aaron Train [:aaronmt]]

If this is still reproducible, I am most concerned about this bug on the tracking list for 6.0 currently. Farhan, please investigate.

Comment 7

[Farhan Patel [:farhan]]

Simon I cant seem to replicate this on v6.x. with the last commit 65ffa16e677206aeb77649b623a4e6f5882139cc

Can you try again? Make sure you close any open tabs -> Restart. And then try to replicate the bug.

Comment 8

[Simon Basca [:SimonB]]

I can still reproduce this issue on beta 6.0b8 and also on latest Nightly.

Can you please try again following these exact steps:

1. Open a New tab 
2. Tap on Bookmarks panel (Be sure this tab remains open in the Bookmark panel)
3. Open the menu and tap on the New tab button
4. In the new tab go to youtube.com (This tab should remain in focus)
5. Go to App Switcher and close Firefox
6. Re-open Firefox (This will restore Firefox with the youtube.com tab in focus)
7. Open tabs tray
8. Go to the tab which was previously open in the Bookmark panel at step 2)

Result: 
- The bookmarks are not displayed. After switching to another panel and returning to the Bookmark panel the bookmarks are correctly displayed.

Comment 9

[Aaron Train [:aaronmt]]

I was able to reproduce this using the steps above on 6.0b8 (have not tried a master build) on my iPhone 7+.

Comment 10

[Farhan Patel [:farhan]]

Attachment: Pull Request V2

Comment 11

[Brian Nicholson (:bnicholson)]

Comment on attachment 8824208 [details] [review]
Pull Request V2

I wish there was better Apple documentation around all of this, but if it works for you then it works for me!

Comment 12

[Farhan Patel [:farhan]]

Attempty 2! 
https://github.com/mozilla-mobile/firefox-ios/commit/72ab4df1a228e82c3f6975839230848e28bc1746

Comment 13

[Simon Basca [:SimonB]]

This issue is no longer reproducible on latest master 72ab4df1.

Comment 14

[Stephan Leroux [:sleroux]]

v6.x 1be63457ee415f8f57bc9258b161635904288ca5

Comment 15

[Adrian Oniga]

Verified as fixed on iPhone 6, iOS 10.2, Firefox version 7.0(1)