Port bug 821291. Remove MOZ_ENABLE_GNOME_COMPONENT from c-c

RESOLVED FIXED in Thunderbird 53.0

Status

MailNews Core
Build Config
--
minor
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

unspecified
Thunderbird 53.0

Thunderbird Tracking Flags

(thunderbird53 fixed, seamonkey2.50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Bug 821291 folded mozgnome.so into libxul and external binary compnents are no longer supported anyway. The only reference where MOZ_ENABLE_GNOME_COMPONENT is still used is in suite. IM and TB only declare it. I think it can be safely removed.
(Assignee)

Comment 1

11 months ago
Created attachment 8816901 [details] [diff] [review]
1322137-mozgnome.patch

Need to do a Linux build first before setting review.
(Assignee)

Comment 2

11 months ago
Comment on attachment 8816901 [details] [diff] [review]
1322137-mozgnome.patch

SeaMonkey Linux build did build and worked. I think IM and TB parts can be removed without a try build.
Attachment #8816901 - Flags: review?(philip.chee)
Attachment #8816901 - Flags: review?(aleth)

Comment 3

11 months ago
Comment on attachment 8816901 [details] [diff] [review]
1322137-mozgnome.patch

Review of attachment 8816901 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanup
Attachment #8816901 - Flags: review?(aleth) → review+

Updated

11 months ago
Attachment #8816901 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 4

11 months ago
https://hg.mozilla.org/comm-central/rev/edfe6af9e70592537a05d22efad7de6a723a8217
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-seamonkey2.50: --- → fixed
status-thunderbird53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.