1322251 - Remove browser.preferences.animateFadeIn and its code

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Remove obsolete not working "browser.preferences.animateFadeIn" preference from about:config and its code,
especially when patches from bug #1140495 and bug #738797 landed very long time ago.

Comment 1

[pass2pawan]

Ready to take this , if someone is ready to mentor

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to pass2pawan from comment #1)
> Ready to take this , if someone is ready to mentor

I can mentor this, please feel free to ask any questions that you may have.

Comment 3

[Sourav Garg [:jordan]]

Hi, I would like to fix this bug, please assign this to me. Thanks!

Comment 4

[Sourav Garg [:jordan]]

Attachment: Bug 1322251 - Remove browser.preferences.animateFadeIn and its code;

Review commit: https://reviewboard.mozilla.org/r/100208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100208/

Comment 5

[Sourav Garg [:jordan]]

Also, I've attached a patch file, due to some reason I'm not able to test it. Please check this, and inform me for any changes.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Hi Jorg, can you please test the attached patch with Thunderbird to make sure we're not breaking your preference implementation?

Comment 7

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. This looks like a theme issue and I'm not a specialist there, but I know someone who is.

Richard, can you please take a look. If you're not so familiar with Review Board, you can download the patch here: https://reviewboard.mozilla.org/r/100208/diff/raw/

Comment 8

[Richard Marti (:Paenglab)]

For the record, SeaMonkey and Instantbird use also the window prefs. And the animation is only used on macOS.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Florian, from the perspective of Instantbird, would you be OK if this pref was removed?

Comment 10

[Richard Marti (:Paenglab)]

I would like if this pref could stay.

And I tested the patch and the prefs are still working except one box which depends on #MailPreferences[animated="true|false"], but this would be easy to fix.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8820774 [details]
Bug 1322251 - Remove browser.preferences.animateFadeIn and its code;

https://reviewboard.mozilla.org/r/100208/#review100794

Ok, thanks for the feedback. We can remove the pref from firefox.js and the /browser/themes files, but please leave /toolkit unchanged.

Comment 12

[Sourav Garg [:jordan]]

Comment on attachment 8820774 [details]
Bug 1322251 - Remove browser.preferences.animateFadeIn and its code;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100208/diff/1-2/

Comment 13

[Sourav Garg [:jordan]]

Jared, I've removed all the changes from /toolkit. Please have a look.

Comment 14

[Florian Quèze [:florian]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> Florian, from the perspective of Instantbird, would you be OK if this pref
> was removed?

Instantbird still uses this pref for OS X, yes.

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8820774 [details]
Bug 1322251 - Remove browser.preferences.animateFadeIn and its code;

https://reviewboard.mozilla.org/r/100208/#review101068

Thanks! I'll get this pushed to autoland. It should make its way in to Firefox Nightly in the next two days :)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/041d65a057dc
Remove browser.preferences.animateFadeIn and its code; r=jaws

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/041d65a057dc

Comment 18

[Philip Chee]

SeaMonkey is ok if this pref is removed.