str_unescape and js_str_escape in jsstr.c ignore OOM errors

VERIFIED FIXED

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: scole, Assigned: khanson)

Tracking

({js1.5})

Trunk
x86
Other
js1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Both str_unescape and js_str_escape in jsstr.c ignore out-of-memory errors
returned by JS_malloc, resulting in crashes if such a situation were to happen.

Patch coming up.
(Reporter)

Comment 1

17 years ago
Created attachment 75132 [details] [diff] [review]
proposed fix
Comment on attachment 75132 [details] [diff] [review]
proposed fix

sr=brendan@mozilla.org, hoping khanson will r= and propose to drivers for 1.0
a= fast.  Thanks, scole!

/be
Attachment #75132 - Flags: superreview+

Updated

17 years ago
Keywords: js1.5, mozilla1.0
Summary: str_unescape and js_str_escape in jsstr.c ignore OOM errors → str_unescape and js_str_escape in jsstr.c ignore OOM errors
(Assignee)

Comment 3

17 years ago
Comment on attachment 75132 [details] [diff] [review]
proposed fix

r=khanson
Attachment #75132 - Flags: review+

Comment 4

17 years ago
Comment on attachment 75132 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75132 - Flags: approval+
(Assignee)

Comment 5

17 years ago
Fixed
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
Marking Verified - 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.