Closed Bug 1322312 Opened 4 years ago Closed 4 years ago

Ensure GC unsafe region count is only updated on the main thread

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

assert-unsafe-region-thread
3.67 KB, patch
sfink
: review+
Details | Diff | Splinter Review 
This patch adds assertions and fixes the one place this currently happens.  I removed AutoCheckCannotGC from ProfilingFrameIterator but it is still covered by the hazard analysis so this should be fine.
Attachment #8817089 - Flags: review?(sphink)
Attachment #8817089 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c30011abb0f2
Assert that GCRuntime::enter/leaveUnsafe region is only used on the main thread r=sfink
https://hg.mozilla.org/mozilla-central/rev/c30011abb0f2
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.