Closed Bug 1322331 Opened 4 years ago Closed 4 years ago

Add Windows 10 detection

Categories

(Toolkit :: NSIS Installer, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

We've added code to detect other OS's due to not being able to get the latest version of NSIS on the build systems (see bug 1236624) and we can do that for windows 10 as well. Patch coming up.
Attached patch patchSplinter Review
Attachment #8817139 - Flags: review?(mhowell)
Attachment #8817139 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a0223e35b0e
Add Windows 10 detection to the installer. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/2a0223e35b0e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8817139 [details] [diff] [review]
patch

Approval Request Comment

[Feature/Bug causing the regression]:
N/A

[User impact if declined]:
We're getting incorrect and misleading data from our stub installer metrics because Windows 10 is being incorrectly detected as 8.1. This isn't a new regression, but it was only recently detected because that data only recently became available to easily query.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
No, it's been verified manually already.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
We've done almost exactly the same thing before for Windows 7, and the change only adds detection for the new version, it doesn't modify any existing ones.

[String changes made/needed]:
N/A
Attachment #8817139 - Flags: approval-mozilla-beta?
Attachment #8817139 - Flags: approval-mozilla-aurora?
Comment on attachment 8817139 [details] [diff] [review]
patch

detect windows 10 in the installer, take in aurora52
Attachment #8817139 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8817139 [details] [diff] [review]
patch

Add detection for win 10. Beta51+. Should be in 51 beta 7.
Attachment #8817139 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.