Closed Bug 1322333 Opened 3 years ago Closed 3 years ago

Misaligned "Account Management" in RTL

Categories

(Firefox :: Theme, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: sh.yaron, Assigned: tomer)

References

()

Details

(Keywords: rtl)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161201172143

Steps to reproduce:

1. Opened Firefox on Mac El Capitan.
2. Clicked the Hamburger menu.
3. Clicked Preferences
4. Clicked Sync on the side menu
5. Logged in to my Sync account (This message won't appear unless the user is signed in)


Actual results:

The "Account management" link is aligned to the right.


Expected results:

The "Account management" link should have a small space between the link and the "Disconnect..." button.
Severity: normal → trivial
Keywords: rtl
OS: Unspecified → Mac OS X
Priority: -- → P1
Hardware: Unspecified → x86_64
Assignee: nobody → tomer.moz.bugs
Status: UNCONFIRMED → ASSIGNED
Component: Untriaged → Theme
Ever confirmed: true
OS: Mac OS X → All
Priority: P1 → --
Hardware: x86_64 → All
Version: 51 Branch → Trunk
Comment on attachment 8817135 [details]
Bug 1322333 Misaligned "Account Management" in RTL

https://reviewboard.mozilla.org/r/97580/#review97894

Thanks for the patch!

Add r?gijs next time and I'll get flagged for the review.

::: browser/themes/shared/incontentprefs/preferences.inc.css:516
(Diff revision 1)
>    margin: 0;
>    min-width: 0;
>  }
>  
> -.fxaAccountBoxButtons > button:first-child {
> +.fxaAccountBoxButtons:dir(ltr) > button:first-child {
>    margin-right: 14px !important;

Instead of selecting for direction, can we use `margin-inline-end` instead?
(In reply to :Gijs Kruitbosch from comment #2)
> Instead of selecting for direction, can we use `margin-inline-end` instead?

We could, and in fact I was thinking about it, but it would cause regression if at some point in the future we'd have top-to-bottom writing direction somewhere. Would you like me to revise the code?

https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-end
Comment on attachment 8817135 [details]
Bug 1322333 Misaligned "Account Management" in RTL

https://reviewboard.mozilla.org/r/97580/#review97994
Attachment #8817135 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d6ea2ff84db7
Misaligned "Account Management" in RTL r=Gijs
https://hg.mozilla.org/mozilla-central/rev/d6ea2ff84db7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.