Closed Bug 1322364 Opened 8 years ago Closed 7 years ago

Release JSS 4.4.0

Categories

(JSS Graveyard :: Library, defect)

Product:
JSS Graveyard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: elio.maldonado.batiz, Assigned: elio.maldonado.batiz)

References

Details

Attachments

(2 files, 2 obsolete files)

Update JSS_{MAJOR,|MINOR|PATCH}_VERSION for jss-4.4.0 release -beta
5.24 KB, patch
mharmsen
: review+
Details | Diff | Splinter Review
turn off beta
558 bytes, patch
mharmsen
: review+
Details | Diff | Splinter Review 
This bug proposes the release of JSS 4.4.0.
Depends on: 1307859
It also updates the required NSPR and NSS versions to the latest ones released.
Attachment #8817198 - Flags: review?(mharmsen)
Attachment #8817198 - Flags: review?(cfu)
Target Milestone: --- → 4.4
Assignee: glenbeasley → emaldona
Temporary patch with more modest nss/nspr version dependencies while we are doing some testing, not ready yet for review review.
Attachment #8817198 - Attachment is obsolete: true
Attachment #8817198 - Flags: review?(mharmsen)
Attachment #8817198 - Flags: review?(cfu)
Notice in the header #define JSS_BETA PR_TRUE as this for beta. When we are ready to the general release we'll cahnge it is back to PR_FALSE. Here I'm following NSS existing practice.
Attachment #8817720 - Attachment is obsolete: true
Attachment #8846188 - Flags: review?(mharmsen)
Comment on attachment 8846188 [details] [diff] [review]
Update JSS_{MAJOR,|MINOR|PATCH}_VERSION for jss-4.4.0 release -beta

CAVEATS:

Add the following to org/mozilla/jss/util/jssver.h:

     /* lib/manifest.mn                                                  */
+    /* jss/manifest.mn                                                  */
     /*                                                                  */
     /********************************************************************/

Change the following in org/mozilla/jss/CryptoManager.c:

     /* lib/manifest.mn                                                  */
-    /* mozilla/security/jss/manifest.mn                                 */
+    /* jss/manifest.mn                                                  */
     /*                                                                  */
     /********************************************************************/

Change the following in lib/manifest.mn:

     /* lib/manifest.mn                                                  */
-    /* mozilla/security/jss/manifest.mn                                 */
+    /* jss/manifest.mn                                                  */
     /*                                                                  */
     /********************************************************************/
Attachment #8846188 - Flags: review?(mharmsen) → review+
Two questions:

(1) As I do not have change access to the upstream repository, and I need to create a new tarball from
    this source to build an "official" downstream build, can we change the following line in
    org/mozilla/jss/util/jssver.h:

    - #define JSS_BETA     PR_TRUE
    + #define JSS_BETA     PR_FALSE

    BTW, I am presuming that an upstream tarball is generated by the following command:
    
    # hg clone https://hg.mozilla.org/projects/jss
    # cd jss
    # hg archive -p jss-4.4.0 -r default -t tgz -I . jss-4.4.0.tar.gz

    (I am guessing that I need the -I . to include the top-level jss directory?

(2) Do we need to include something like the following in jss/lib/jss.def:

;+JSS_4.3.2 {     # JSS 4.3.2 release
;+    global:
;+        ;
;+    local:
;+       *;
;+};
;+JSS_4.4.0 {     # JSS 4.4.0 release
;+    global:
;+        ;
;+    local:
;+       *;
;+};
Flags: needinfo?(emaldona)
(In reply to Matthew Harmsen from comment #5)
> Two questions:
> 
> (1) As I do not have change access to the upstream repository, and I need to
> create a new tarball from
>     this source to build an "official" downstream build, can we change the
> following line in
>     org/mozilla/jss/util/jssver.h:
> 
>     - #define JSS_BETA     PR_TRUE
>     + #define JSS_BETA     PR_FALSE
> 
>     BTW, I am presuming that an upstream tarball is generated by the
> following command:
>     
>     # hg clone https://hg.mozilla.org/projects/jss
>     # cd jss
>     # hg archive -p jss-4.4.0 -r default -t tgz -I . jss-4.4.0.tar.gz
> 
>     (I am guessing that I need the -I . to include the top-level jss
> directory?
> 

figured out that the command was:

      # hg archive -p jss-4.4.0/jss -r default -t tgz jss-4.4.0.tar.g

> (2) Do we need to include something like the following in jss/lib/jss.def:
> 
> ;+JSS_4.3.2 {     # JSS 4.3.2 release
> ;+    global:
> ;+        ;
> ;+    local:
> ;+       *;
> ;+};
> ;+JSS_4.4.0 {     # JSS 4.4.0 release
> ;+    global:
> ;+        ;
> ;+    local:
> ;+       *;
> ;+};
figured out that the command was:

      # hg archive -p jss-4.4.0/jss -r default -t tgz jss-4.4.0.tar.gz

pesky typos!
(In reply to Matthew Harmsen from comment #5)
> Two questions:
> 
> (1) As I do not have change access to the upstream repository, and I need to
> create a new tarball from
>     this source to build an "official" downstream build, can we change the
> following line in
>     org/mozilla/jss/util/jssver.h:
> 
>     - #define JSS_BETA     PR_TRUE
>     + #define JSS_BETA     PR_FALSE
> 
>     BTW, I am presuming that an upstream tarball is generated by the
> following command:
>     
>     # hg clone https://hg.mozilla.org/projects/jss
>     # cd jss
>     # hg archive -p jss-4.4.0 -r default -t tgz -I . jss-4.4.0.tar.gz
> 
>     (I am guessing that I need the -I . to include the top-level jss
> directory?
> 
> (2) Do we need to include something like the following in jss/lib/jss.def:
> 
> ;+JSS_4.3.2 {     # JSS 4.3.2 release
> ;+    global:
> ;+        ;
> ;+    local:
> ;+       *;
> ;+};
> ;+JSS_4.4.0 {     # JSS 4.4.0 release
> ;+    global:
> ;+        ;
> ;+    local:
> ;+       *;
> ;+};

Waht that says is is that JSS_4.3.2 was added and had no new functions added. Likewise for the upcoming 4.4.0. It seems a bit odd. I need to look at what they do for NSS in cases like that, I think nothing at all is added, I'll check on that. Proceure is likely documented.
Flags: needinfo?(emaldona)
I looked at various nss .def file, nss.def, ssl.def, softokn.def, and util.def and there is never any 
NSS_X.Y.Z { section added unless new functions need to be exported to client code. The extreme case is in softokn.def with only on entry, "NSS_3.4 { # NSS 3.4 release". My recommendation is to not add those two entries with nothing in them at all.
(In reply to Elio Maldonado from comment #9)
> I looked at various nss .def file, nss.def, ssl.def, softokn.def, and
> util.def and there is never any 
> NSS_X.Y.Z { section added unless new functions need to be exported to client
> code. The extreme case is in softokn.def with only on entry, "NSS_3.4 { #
> NSS 3.4 release". My recommendation is to not add those two entries with
> nothing in them at all.

cool -- thanks for checking this!

Also, I have thought about a compromise on the "#define JSS_BETA     PR_TRUE" --- the value in the source will not matter as long as you place the information that this "may" need to be changed when one is creating a downstream tarball.

For example:

# The source for this package was pulled from upstream's hg. Use the
# following commands to generate the tarball:
# hg clone --rev JSS_4_4_0_RTM https://hg.mozilla.org/projects/jss jss-4.4.0/jss
# rm -r jss-4.4.0/jss/.hg
# edit jss-4.4.0/jss/org/mozilla/jss/util/jssver.h and change the following value as appropriate:
#      #define JSS_BETA     PR_TRUE -- or --
#      #define JSS_BETA     PR_FALSE
# tar -czvf jss-4.4.0.tar.gz jss-4.4.0
Fine as long as it's documented somewhere.
Pushed: https://hg.mozilla.org/projects/jss/rev/c63c478b43edaf0d4eb6b68e5767987b9a010765
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Forgot to do what you requested in Comment 4. Need another push.
It must stay open until we do the JSS_4_4_0_RTM tagging.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch turn off beta — — Splinter Review 

        Attachment #8846802 -
        Flags: review?(mharmsen)

    
    

    
  
Comment on attachment 8846802 [details] [diff] [review]
turn off beta

ACK

-- we can still document this at the top of the spec files

        Attachment #8846802 -
        Flags: review?(mharmsen) → review+

    
  
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: