Closed
Bug 1322380
Opened 8 years ago
Closed 8 years ago
Improve GC profiling output
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(2 files)
6.16 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
2.59 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
At the moment the header lines which describe what each field means are printed at different times for the nursery and major GC profile, depending on how many lines are output for each. This makes the output even more confusing when these are both enabled. This patch prints them both at the same time.
Attachment #8817210 -
Flags: review?(sphink)
Assignee | ||
Comment 2•8 years ago
|
||
The major GC profile information doesn't line up correctly under the column headings because they're longer than six characters. This patch fixes that by shortening the column names.
Attachment #8817211 -
Flags: review?(sphink)
Comment 3•8 years ago
|
||
Comment on attachment 8817210 [details] [diff] [review] print-profile-headers-together Review of attachment 8817210 [details] [diff] [review]: ----------------------------------------------------------------- nice cleanup
Attachment #8817210 -
Flags: review?(sphink) → review+
Updated•8 years ago
|
Attachment #8817211 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d01ac7a95ee4 Print major / minor GC profiling headers together if both enabled r=sfink https://hg.mozilla.org/integration/mozilla-inbound/rev/c2626a3d815c Fix alignment of major GC profiling headers r=sfink
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d01ac7a95ee4 https://hg.mozilla.org/mozilla-central/rev/c2626a3d815c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•