Closed Bug 1322380 Opened 3 years ago Closed 3 years ago

Improve GC profiling output

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(2 files)

No description provided.
At the moment the header lines which describe what each field means are printed at different times for the nursery and major GC profile, depending on how many lines are output for each.  This makes the output even more confusing when these are both enabled.

This patch prints them both at the same time.
Attachment #8817210 - Flags: review?(sphink)
The major GC profile information doesn't line up correctly under the column headings because they're longer than six characters.  This patch fixes that by shortening the column names.
Attachment #8817211 - Flags: review?(sphink)
Comment on attachment 8817210 [details] [diff] [review]
print-profile-headers-together

Review of attachment 8817210 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup
Attachment #8817210 - Flags: review?(sphink) → review+
Attachment #8817211 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d01ac7a95ee4
Print major / minor GC profiling headers together if both enabled r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2626a3d815c
Fix alignment of major GC profiling headers r=sfink
https://hg.mozilla.org/mozilla-central/rev/d01ac7a95ee4
https://hg.mozilla.org/mozilla-central/rev/c2626a3d815c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.