Closed
Bug 1322443
Opened 8 years ago
Closed 8 years ago
Report the execution of Irregexp in ion
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Assignee: nobody → hv1989
Attachment #8817328 -
Flags: review?(bbouvier)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8817328 [details] [diff] [review] Patch Review of attachment 8817328 [details] [diff] [review]: ----------------------------------------------------------------- Works for me. I see there are many other rolled-in assembly instructions above and below, but it's not convenient to start the TL earlier (resp. stop later) because there's a failure path (or the failure path could duplicate the TL stopping?) and a notFound path. Anyways, I guess the big fish is in the regexp execution itself, so that looks good enough. Thanks!
Attachment #8817328 -
Flags: review?(bbouvier) → review+
Pushed by hv1989@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8faf0055fb54 TraceLogging: Report irregexp execution in Ion, r=bbouvier
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8faf0055fb54
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•