1322458 - Fix KungFuDeathGrip errors that clang plugin reports on Windows

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Comment 1

[Ting-Yu Chou [:ting] (away)]

Attachment: wip

Comment 2

[Ting-Yu Chou [:ting] (away)]

Attachment: Bug 1322458 - Fix kungFuDeathGrip errors that clang plugin reports on Windows.

Review commit: https://reviewboard.mozilla.org/r/98564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98564/

Comment 3

[(no longer active)]

Comment on attachment 8818737 [details]
Bug 1322458 - Fix kungFuDeathGrip errors that clang plugin reports on Windows.

https://reviewboard.mozilla.org/r/98564/#review99002

::: ipc/mscom/WeakRef.cpp:45
(Diff revision 1)
>    }
>    *ppv = nullptr;
>  
>    // Raise the refcount for stabilization purposes during aggregation
>    RefPtr<IUnknown> kungFuDeathGrip(static_cast<IUnknown*>(this));
> +  Unused << kungFuDeathGrip;

Nit: I think if you remove the static_cast here and just pass |this| directly, then the analysis would ignore this instance.  Can you please try that?  If that doesn't work, then the patch is fine as is.

::: widget/windows/TSFTextStore.cpp:1724
(Diff revision 1)
>      mHasReturnedNoLayoutError = false;
>      return;
>    }
>  
>    RefPtr<nsWindowBase> kungFuDeathGrip(mWidget);
> +  Unused << kungFuDeathGrip;

Instead of doing this, you need to give this a better name and use this variable everywhere further down this function instead of mWidget.  This is a legit issue that the analysis has found.  :-)

Comment 4

[Ting-Yu Chou [:ting] (away)]

Comment on attachment 8818737 [details]
Bug 1322458 - Fix kungFuDeathGrip errors that clang plugin reports on Windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98564/diff/1-2/

Comment 5

[(no longer active)]

Comment on attachment 8818737 [details]
Bug 1322458 - Fix kungFuDeathGrip errors that clang plugin reports on Windows.

https://reviewboard.mozilla.org/r/98564/#review99142

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8818737 [details]
Bug 1322458 - Fix kungFuDeathGrip errors that clang plugin reports on Windows.

https://reviewboard.mozilla.org/r/98564/#review99184

Thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6171fec299c6
Fix kungFuDeathGrip errors that clang plugin reports on Windows. r=aklotz,Ehsan

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6171fec299c6