Closed Bug 1322464 Opened 3 years ago Closed 3 years ago

Fix invalid assignment in assertion that clang plugin reports on Windows

Categories

(Firefox Build System :: Source Code Analysis, defect)

Unspecified
Windows
defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ting, Assigned: ting)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Can you post here what error you have, I remember that we have a checker that checks for assignments in assertions and marks them as errors.
Attached file wip (obsolete) —
Attachment #8817355 - Flags: feedback?(bertbelder)
The error message:

 1:28.05 c:/w/fx/mc/js/src/threading/windows/ConditionVariable.cpp(271,7):  error(clang): Forbidden assignment in assert expression
 1:28.05       MOZ_RELEASE_ASSERT(waitResult = WAIT_OBJECT_0 + 1 ||
 1:28.05       ^
Attachment #8817373 - Flags: feedback?(bertbelder)
Attachment #8817355 - Attachment is obsolete: true
Attachment #8817355 - Flags: feedback?(bertbelder)
Comment on attachment 8817373 [details]
Bug 1322464 - Fix an invalid assignment in assertion expression.

https://reviewboard.mozilla.org/r/97668/#review98018

Bleh, I think I even reviewed this code!  Thank you for the patch.
Attachment #8817373 - Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/406807fc751e
Fix an invalid assignment in assertion expression. r=froydnj
Assignee: nobody → janus926
https://hg.mozilla.org/mozilla-central/rev/406807fc751e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Attachment #8817373 - Flags: feedback?(bertbelder)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.