Closed Bug 1322464 Opened 3 years ago Closed 3 years ago
Fix invalid assignment in assertion that clang plugin reports on Windows
58 bytes, text/x-review-board-request
No description provided.
Can you post here what error you have, I remember that we have a checker that checks for assignments in assertions and marks them as errors.
The error message: 1:28.05 c:/w/fx/mc/js/src/threading/windows/ConditionVariable.cpp(271,7): error(clang): Forbidden assignment in assert expression 1:28.05 MOZ_RELEASE_ASSERT(waitResult = WAIT_OBJECT_0 + 1 || 1:28.05 ^
Comment on attachment 8817373 [details] Bug 1322464 - Fix an invalid assignment in assertion expression. https://reviewboard.mozilla.org/r/97668/#review98018 Bleh, I think I even reviewed this code! Thank you for the patch.
Attachment #8817373 - Flags: review?(nfroyd) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/406807fc751e Fix an invalid assignment in assertion expression. r=froydnj
You need to log in before you can comment on or make changes to this bug.