1322536 - Make some mScanInProgress checks MOZ_RELEASE_ASSERT

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

The cycle collector uses mScanInProgress to guard against reentrance. We assert that it isn't true in a number of places. A few of those places are at the start of CC phases. We might as well make those asserts fatal, because we don't call them much, so it would be cheap to do.

Comment 1

[Andrew McCreight [:mccr8]]

try looks reasonably green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f600739da456f87d8020a20c1cb354907f15c506

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1322536 - Make some mScanInProgress checks fatal in release builds.

Review commit: https://reviewboard.mozilla.org/r/97730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97730/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8817519 [details]
Bug 1322536 - Make some mScanInProgress checks fatal in release builds.

https://reviewboard.mozilla.org/r/97730/#review98118

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3be54c62e001
Make some mScanInProgress checks fatal in release builds. r=smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3be54c62e001

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8817519 [details]
Bug 1322536 - Make some mScanInProgress checks fatal in release builds.

Approval Request Comment
[Feature/Bug causing the regression]: unknown
[User impact if declined]: I am investigating a crash.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: The crash has been on Nightly for a few days without any obvious stability problems.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This patch makes us crash in release builds in certain conditions. If we hit that condition, even without this patch, very bad things are likely to happen, so this should only improve things, because at least we're crashing cleanly.
[String changes made/needed]: none

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8817519 [details]
Bug 1322536 - Make some mScanInProgress checks fatal in release builds.

This patch can help investigate a crash. Beta51+ and Aurora52+. Should be in 51 beta 8.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce2f7cf67b81

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8dfde2264fdf