Closed
Bug 1322550
Opened 8 years ago
Closed 7 years ago
Rename DOMStorage to Storage
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
213.18 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8817487 -
Flags: review?(bugs)
Comment 1•8 years ago
|
||
Comment on attachment 8817487 [details] [diff] [review] storage.patch >+ // Principal the cache has been initially created for, this is used only for >+ // sessionStorage access checks since sessionStorage objects are strictly >+ // scoped by a principal. localStorage objects on the other hand are scoped >+ // by origin only. extra space before localStorage >-DOMStorageDBThread::ThreadObserver::OnDispatchedEvent(nsIThreadInternal *thread) >+StorageDBThread::ThreadObserver::OnDispatchedEvent(nsIThreadInternal *thread) ... > NS_IMETHODIMP >-DOMStorageDBThread::ThreadObserver::OnProcessNextEvent(nsIThreadInternal *thread, >- bool mayWait) >+StorageDBThread::ThreadObserver::OnProcessNextEvent(nsIThreadInternal *thread, >+ bool mayWait) ... >-DOMStorageDBThread::ThreadObserver::AfterProcessNextEvent(nsIThreadInternal *thread, >- bool eventWasProcessed) >+StorageDBThread::ThreadObserver::AfterProcessNextEvent(nsIThreadInternal *thread, >+ bool eventWasProcessed) I wouldn't mind if you fixed the argument naming here to use form Type aName > // Database open and all initiation operation are done. Switching this flag >- // to true allow main thread to read directly from the database. >- // If we would allow this sooner, we would have opened a window where main thread >- // read might operate on a totaly broken and incosistent database. >+ // to true allow main thread to read directly from the database. If we would >+ // allow this sooner, we would have opened a window where main thread read >+ // might operate on a totaly broken and incosistent database. while you're here, s/totaly/totally/? >+ // Executes the previously |Prepared()'ed| list of operations, retuns returns > // Since this manager is sessionStorage manager, PutCache hard references > // the cache in our hashtable. >- RefPtr<DOMStorageCache> newCache = PutCache(origCache->OriginSuffix(), >+ RefPtr<StorageCache> newCache = PutCache(origCache->OriginSuffix(), > origCache->OriginNoSuffix(), > origCache->Principal()); fix indentation >-// Statically (though layout statics) initialized observer receiving and processing >-// chrome clearing notifications, such as cookie deletion etc. >-class DOMStorageObserver : public nsIObserver >- , public nsSupportsWeakReference >+// Statically (though layout statics) initialized observer receiving and While you're here, shouldn't it be 'through' and not 'though'
Attachment #8817487 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5c83df4b3e89 Rename DOMStorage to Storage, r=smaug
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5c83df4b3e89
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•