1322602 - Remove the capability of video casting from Fennec to Firefox OS TV

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

This feature (see Bug 1129785) is no longer useful based on the latest status of Firefox OS development.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1322602 - remove Fennec-to-FxOSTV video casting.

Review commit: https://reviewboard.mozilla.org/r/97788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97788/

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Not sure who can review this code, maybe @rbarker can help?

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

https://reviewboard.mozilla.org/r/97788/#review98238

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

https://reviewboard.mozilla.org/r/97788/#review98240

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14617919dace
remove Fennec-to-FxOSTV video casting. r=rbarker

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/14617919dace

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

this code created a performance win for testing on a real device and measuring page load time:
https://treeherder.mozilla.org/perf.html#/alerts?id=4507

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

Approval Request Comment
[Feature/Bug causing the regression]: Unknown
[User impact if declined]: Frequent hangs and unusable slowness in Firefox 52
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: If you simply use Firefox with a Chromecast on the network, it's unusably slow. This patch should fix that.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Sorta
[Why is the change risky/not risky?]: Mostly removes code, but does trigger usage of a different mDNS path.
[String changes made/needed]: None

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Doesn't apply:

grafting 360193:14617919dace "Bug 1322602 - remove Fennec-to-FxOSTV video casting. r=rbarker"
merging mobile/android/app/mobile.js
merging mobile/android/chrome/content/browser.js
merging toolkit/modules/moz.build
warning: conflicts while merging mobile/android/app/mobile.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/modules/moz.build! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

OK, I think maybe we just want to flip the pref as described in bug 1347755

Comment 11

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: uplift-for-release.patch

Rebased for release branch

Comment 12

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

patch provided for uplifting. You can either disable prefs I mentioned in bug 1347755 comment #20, or uplift this bug.

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Thanks for the patch! I think the easiest thing for 52 is to just disable the prefs, and I have a patch up that does just that.

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

we went with the patch in bug 1347755 instead.