Closed Bug 1322602 Opened 3 years ago Closed 3 years ago

Remove the capability of video casting from Fennec to Firefox OS TV

Categories

(Firefox for Android :: Screencasting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: schien, Assigned: schien)

Details

Attachments

(2 files)

This feature (see Bug 1129785) is no longer useful based on the latest status of Firefox OS development.
Not sure who can review this code, maybe @rbarker can help?
Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

https://reviewboard.mozilla.org/r/97788/#review98238
Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

https://reviewboard.mozilla.org/r/97788/#review98240
Attachment #8817534 - Flags: review?(rbarker) → review+
Pushed by schien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14617919dace
remove Fennec-to-FxOSTV video casting. r=rbarker
https://hg.mozilla.org/mozilla-central/rev/14617919dace
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
this code created a performance win for testing on a real device and measuring page load time:
https://treeherder.mozilla.org/perf.html#/alerts?id=4507
Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

Approval Request Comment
[Feature/Bug causing the regression]: Unknown
[User impact if declined]: Frequent hangs and unusable slowness in Firefox 52
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: If you simply use Firefox with a Chromecast on the network, it's unusably slow. This patch should fix that.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Sorta
[Why is the change risky/not risky?]: Mostly removes code, but does trigger usage of a different mDNS path.
[String changes made/needed]: None
Attachment #8817534 - Flags: approval-mozilla-release?
Doesn't apply:

grafting 360193:14617919dace "Bug 1322602 - remove Fennec-to-FxOSTV video casting. r=rbarker"
merging mobile/android/app/mobile.js
merging mobile/android/chrome/content/browser.js
merging toolkit/modules/moz.build
warning: conflicts while merging mobile/android/app/mobile.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/modules/moz.build! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(snorp)
OK, I think maybe we just want to flip the pref as described in bug 1347755
Flags: needinfo?(snorp)
Rebased for release branch
patch provided for uplifting. You can either disable prefs I mentioned in bug 1347755 comment #20, or uplift this bug.
Flags: needinfo?(snorp)
Thanks for the patch! I think the easiest thing for 52 is to just disable the prefs, and I have a patch up that does just that.
Comment on attachment 8817534 [details]
Bug 1322602 - remove Fennec-to-FxOSTV video casting.

we went with the patch in bug 1347755 instead.
Attachment #8817534 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.