Closed
Bug 1322619
Opened 8 years ago
Closed 7 years ago
Don't mask uncaught exceptions on shutdown
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
Details
Attachments
(1 file)
|
1.93 KB,
patch
|
droeh
:
review+
|
Details | Diff | Splinter Review |
We currently ignore uncaught exceptions when shutting down, but all that does is letting the crashing thread die and potentially preventing shutdown.
|
Assignee | |
Comment 1•7 years ago
|
||
We used to mask exceptions on shutdown due to calling System.exit for shutting down. Now we simply kill the process, so there's no need to mask exceptions anymore.
Attachment #8895895 -
Flags: review?(droeh)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8895895 [details] [diff] [review] Don't mask exceptions on shutdown (v1) Review of attachment 8895895 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8895895 -
Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b9dac0c4cf3 Don't mask exceptions on shutdown; r=droeh
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1b9dac0c4cf3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•