Closed Bug 132267 Opened 18 years ago Closed 14 years ago

[RFE] Chatzilla transfers should use Download Manager

Categories

(Other Applications :: ChatZilla, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: xyzzy, Assigned: rginda)

References

(Blocks 1 open bug)

Details

This is a still a little ways off, but it would be nice to have DCC downloads
show up in the Download Manager.  If the Download Manager ever supports uploads,
uploads should be supported as well.
Depends on: 73257
Summary: [RFE] Chatzilla transfers should use Dowload Manager → [RFE] Chatzilla transfers should use Download Manager
Good idea oh lord. :)
Blocks: 251983
That or get a different (independant from main app) download manager, either as
a single window (Firefox-like) or as a single tab handling all the DCC
transferts (sends/gets).

Some kind of auto-accept (chats, gets, sends) would also be very appreciated,
either as a trigger (auto/manual) or as a white list (far more secure).

Last would be the possibility to setup an fserve/XDCC/TDCC, but these are merely
long-term suggestions
Product: Core → Other Applications
(In reply to comment #0)
> This is a still a little ways off, but it would be nice to have DCC downloads
> show up in the Download Manager.  If the Download Manager ever supports uploads,
> uploads should be supported as well.

That'd be hard to do, I think. Particularly because I'm not sure whether
XULRunner comes with a download manager, or how we'd integrate third party
download managers  (which is possible with Firefox or Mozilla, IIRC).
If it's not possible with XULRunner, I suggest this be marked WONTFIXED. 
Also, what exactly would be the advantages of using the download mananger?
Pausing a dcc download is not supported, afaik. So that's off already. All it
would really show is the progress, and that is something which is already shown.
As for the transfer rate, when last I looked, that was buggy in DL manager
anyway, but it's not exactly hard to implement in Chatzilla either.
(In reply to comment #3)
> That'd be hard to do, I think. Particularly because I'm not sure whether
> XULRunner comes with a download manager, or how we'd integrate third party
> download managers  (which is possible with Firefox or Mozilla, IIRC).

Not a problem, you just check if the download manager is present in the build or
not, by using it's class ID "mozilla.org/download-manager".

This bug is not about making it possible to integrate it with other download
managers, but to integrate it with "Download Manager".

> If it's not possible with XULRunner, I suggest this be marked WONTFIXED.

It is possible. In any case, it shouldn't be marked WONTFIX if it was. The bug
would still be a *perfectly* valid RFE.
 
> Also, what exactly would be the advantages of using the download mananger?

You get all your downloads in one list.

> Pausing a dcc download is not supported, afaik.

We'll just disable the pause button and/or menu entry, then.
(In reply to comment #4)
> (In reply to comment #3)

> Not a problem, you just check if the download manager is present in the build or
> not, by using it's class ID "mozilla.org/download-manager".

in XULRunner:
[EVAL-IN]
Components.classes["@mozilla.org/download-manager;1"].getService(Components.interfaces.nsIDownloadManager);
[ERROR]	TypeError: Components.classes['@mozilla.org/download-manager;1'] has no
properties

Apparently not.

> > If it's not possible with XULRunner, I suggest this be marked WONTFIXED.
> 
> It is possible. In any case, it shouldn't be marked WONTFIX if it was. The bug
> would still be a *perfectly* valid RFE.

ReadMe suggested on IRC that we could simply try to use DL Manager in the code,
and fall back to the current way of doing stuff if we fail (which would give
different results in XULRunner and Mozilla, taking the above into account). I
suppose that's still a possibility :-)
(In reply to comment #5)
> in XULRunner:
> Apparently not.

The reason I said that was to point out exactly the same thing "ReadMe suggested
on IRC."
(In reply to comment #4)
> Not a problem, you just check if the download manager is present in the build or
> not, by using it's class ID "mozilla.org/download-manager".

Sure, we can tell if it is there. But what if it isn't? What do you suggest
ChatZilla do if it is not there?

> > If it's not possible with XULRunner, I suggest this be marked WONTFIXED.
> 
> It is possible. In any case, it shouldn't be marked WONTFIX if it was. The bug
> would still be a *perfectly* valid RFE.

WONTIFX is not about being a valid RFE. If it was NOT a valid RFE, it would be
marked INVALID. WONTFIX means the bug is a valid bug, but we're not going to fix it.

> > Also, what exactly would be the advantages of using the download mananger?
> 
> You get all your downloads in one list.
> 
> > Pausing a dcc download is not supported, afaik.
> 
> We'll just disable the pause button and/or menu entry, then.

Have you checked if that is possible in both Mozilla and Firefox? I think it is,
but you never know which these things.

I have not looked into how we could use either browser's download manager in
detail, and if someone would do so and indicate the basic interfaces used, and
what can be achieved (and how), that would be good. For now, I'm going to leave
the bug open, in particular because if XULrunner *does* have the download
manager, this continues to make sense (if it doesn't, this bug is on some thin ice).
OK, Bugzilla screwed up badly on this bug. My comment, labeled #7, was made
after comment #4 and Bugzilla DID NOT tell me other people had commented in
between me loading it and submitting.

From comment #5, we are now on thin ice. This bug is not likely to happen.

The reason is simple, duplication. ChatZilla must work on XULrunner, thus is
must have whatever download support is nessessary for that to be usable. I do
not wish to code decent support for DCC FILE within ChatZilla *and* all the
wrapper code that will be nessessary ot use any existing download manager. Note
that I don't plan to implement an entire download manager - that would be silly
- but ChatZilla's DCC FILE needs some more work to be properly useful (e.g. show
speed of transfer).
This is being WONTFIXed because:
  - Mozilla and Firefox have quite different download managers.
  - XULRunner doesn't even have one.
  - The user experience needs to be consitent across hosts, or we get into a
    support hell.
  - Writing two sets of wrappers, and an entire download manager ourselves, is
    simply not going to work in the long run (using our own one on Firefox and
    Mozilla would also be bad, before anyone suggests that).

There is already work being done to allow a default downloads folder, and similar improvements to DCC transfers. I do not believe we need to try a hack this mess up.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.