1322710 - IllegalStateException when setting GeckoEditable.DEBUG to true

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Setting GeckoEditable.DEBUG to true and using IME will cause an IllegalStateException in syncShadowText.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't use SpannableStringBuilder.equals (v1)

Don't use the system SpannableStringBuilder.equals implementation,
because of a bug in Android N+ that incorrectly compares spans.

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8817655 [details] [diff] [review]
Don't use SpannableStringBuilder.equals (v1)

Review of attachment 8817655 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java
@@ +364,5 @@
> +
> +        final Object[] o1s = s1.getSpans(0, s1.length(), Object.class);
> +        final Object[] o2s = s2.getSpans(0, s2.length(), Object.class);
> +
> +o1_loop:

Indendation and style.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75790798dd71
Don't use SpannableStringBuilder.equals; r=esawin

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/75790798dd71